Add API versioning to push notifications API #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianschoffke
approved these changes
Dec 9, 2025
Contributor
florianschoffke
left a comment
florianschoffke
left a comment
There was a problem hiding this comment.
Das ist glaube ich worauf wir uns geeinigt hatten.
Wäre es noch mal eine Überlegung einen Pfadbestandteil "push" einzuführen? Wird es da irgendwann noch mehr geben?
Also bspw. https://erp.zentral.erp.splitdns.ti-dienste.de/**push**/pushers/v1/set?
| openapi: 3.0.3 | ||
| info: | ||
| title: E-Rezept-Fachdienst API for Push Notifications | ||
| version: 1.0.0 |
Contributor
There was a problem hiding this comment.
Hier könnte man sich vermutlich streiten ob das "nur" ein Minor Update ist. Da es aber noch nicht produktiv ist, ist es für mich ok.
Contributor
Author
There was a problem hiding this comment.
Wie meinst du:
Wird es da irgendwann noch mehr geben?
Contributor
There was a problem hiding this comment.
Mehr Endpunkte?
push/superpush
push/differentpush
Also wird das Modul ausgebaut?
So oder so könnte man darüber nachdenken es als Modul im Pfad anzugeben
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement versioning for the push notifications API endpoints to enhance clarity and maintainability. Update the API documentation accordingly.