Skip to content

init modify#29

Merged
f-peverali merged 9 commits intomainfrom
feature/modify-deploy-path
Jan 21, 2026
Merged

init modify#29
f-peverali merged 9 commits intomainfrom
feature/modify-deploy-path

Conversation

@f-peverali
Copy link
Copy Markdown
Contributor

Add option to manually changing deploy path.

fixes #28

@f-peverali f-peverali marked this pull request as draft January 20, 2026 08:34
@f-peverali f-peverali marked this pull request as ready for review January 20, 2026 09:58
@f-peverali f-peverali requested a review from Copilot January 20, 2026 09:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds functionality to allow manual modification of the deployment path during the deployment process. When deploying (but not promoting), users can now choose to modify the target path interactively if they decline the initial confirmation.

Changes:

  • Added a new helper function confirm_with_path_modification that prompts users to confirm or modify a path
  • Updated the deploy_ig function to use path modification for non-promote deployments
  • Imported the new helper function in the deploy module

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
src/fhir_scripts/helper.py Added confirm_with_path_modification function to support interactive path modification with confirmation
src/fhir_scripts/deploy.py Integrated path modification option into the deployment workflow for non-promote scenarios

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/fhir_scripts/helper.py Outdated
Comment thread src/fhir_scripts/helper.py
Comment thread src/fhir_scripts/helper.py Outdated
Comment thread src/fhir_scripts/deploy.py Outdated
f-peverali and others added 3 commits January 20, 2026 11:03
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@f-peverali f-peverali requested a review from cybernop January 20, 2026 10:06
Copy link
Copy Markdown
Contributor

@cybernop cybernop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new entry in the release notes for a new minor release and update pyproject.toml accordingly.

The other parts look fine.

@f-peverali f-peverali requested a review from cybernop January 21, 2026 08:21
@f-peverali f-peverali merged commit 10a2649 into main Jan 21, 2026
2 checks passed
@f-peverali f-peverali deleted the feature/modify-deploy-path branch January 21, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants