Skip to content

Translate filter on Select2 placeholder #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcrombez wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Translate filter on Select2 placeholder #388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Resources/views/Form/jquery_layout.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,6 +656,10 @@
<script type="text/javascript">
jQuery(document).ready(function($) {
$field = $('#{{ id }}');
{% if configs.placeholder is defined %}
{% set configs = {'placeholder': configs.placeholder|trans} + configs %}
Copy link

@Neirda24 Neirda24 Sep 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

{% set configs.placeholder = configs.placeholder|trans %}

would be better optmized.
Also a possibility to fetch the translation domain from the form config itself

Copy link

@benschumi benschumi Dec 8, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neirda24, your code doesn't work.

Unexpected token "punctuation" of value "." ("end of statement block" expected) in GenemuFormBundle:Form:jquery_layout.html.twig at line 661.

The original method by jcrombez work well
{% set configs = {'placeholder': configs.placeholder|trans} + configs %}
but i prefer this
{% set configs = configs|merge({"placeholder": configs.placeholder|trans}) %}

{% endif %}
{% block genemu_jqueryselect2_javascript_prototype %}
$field.select2({{ configs|json_encode|raw }});
Expand Down