fix(genkit): ensure devmode strictly checks for env var#196
Open
MichaelDoyle wants to merge 1 commit into
Open
fix(genkit): ensure devmode strictly checks for env var#196MichaelDoyle wants to merge 1 commit into
MichaelDoyle wants to merge 1 commit into
Conversation
MichaelDoyle
force-pushed
the
fix-genkit-env-dev-mode
branch
from
408fd75 to
da93c85
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors error handling to ensure trace IDs are consistently captured and included in error responses across the core library and the reflection server. Key changes include the addition of trace ID propagation in Tracer, centralized error formatting in ReflectionServer, and the removal of unused fields in ActionDef. New tests were added to verify trace ID inclusion in error outputs. I have no further feedback to provide.
MichaelDoyle
force-pushed
the
fix-genkit-env-dev-mode
branch
from
da93c85 to
312b9dc
Compare
MichaelDoyle
changed the title
MichaelDoyle
changed the title
xavidop
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure devMode strictly checks for GENKIT_ENV=dev case-insensitively instead of defaulting to true when unset.