feat(genkit): implement reflection server port retry range#197
Open
MichaelDoyle wants to merge 1 commit into
Open
feat(genkit): implement reflection server port retry range#197MichaelDoyle wants to merge 1 commit into
MichaelDoyle wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements a port-probing mechanism for the reflection server, allowing it to attempt starting on a range of ports (basePort to basePort + 100) if the initial port is occupied. The review feedback identifies several critical issues: a potential NullPointerException in the error handling logic, incorrect port reporting when using port 0 (ephemeral ports), and a recommendation to use local variables for the server instance during the retry loop to ensure state consistency and safer cleanup.
MichaelDoyle
force-pushed
the
feat-reflection-port-range
branch
from
5f50c09 to
5ae2ea8
Compare
xavidop
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement port retry range (basePort..basePort+100) for reflection server startup, aligning behavior with TypeScript and Go SDKs.