docs(js/agents): added agents samples#5254
Draft
pavelgj wants to merge 47 commits into
Draft
Conversation
Upgrade postcss from 8.4.31 to 8.5.12 across all workspaces and add new markdown/MDX-related dependencies (remark, rehype, unified, etc.) to the lockfile.
Introduce a new "Branching (Variants)" agent that generates multiple name suggestions and lets users pick one. Adds the nameAgent backend flow, Express API routes, a BranchingChat page with variant card UI, and navigation/routing integration in the test app.
Replaced the translatorAgent with a more comprehensive writerAgent in the agents test application. The new writerPrompt utilizes multiple input variables (tone, format, audience) rather than a single language parameter. This update better demonstrates how defineSessionFlowFromPrompt handles multiple prompt input variables. It showcases how a client can supply variables during initialization to dynamically reshape the agent's behavior at runtime without modifying server code. Related Express routes, console logs, and test flows have been updated to reflect the new agent and prompt names.
… apps Export AgentInit, AgentInput, AgentOutput, and AgentStreamChunk types from the genkit/beta entry point. Replace `as any` casts in the agents test app with proper generic type parameters for runFlow/streamFlow, improving type safety across BackgroundAgent and BankingInterrupt pages.
Add a new custom-state-agent (task tracker) to the agents test app, including Express API routes, a React TaskTrackerPage component with a chat + task sidebar UI, and associated styles for progress bars, task lists, and state visualization.
…lify workspaceAgent - Rename `simple-agent` to `custom-agent` and update all imports, routes, and log messages accordingly - Refactor `workspace-builder.ts` to use `defineAgent` instead of `defineCustomAgent`, leveraging the standard agent API for model calls, tool dispatch, streaming, and message management - Extract `emitArtifact` tool to module scope using `ai.defineTool`
Add a custom Handlebars helper `roundRobin` that alternates between two options on each invocation. Update the nameAgent's system prompt to use the helper for switching between 'sarcastic' and 'business-like' assistant personalities.
github-actions
Bot
added
docs
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive test application for Genkit Agents, featuring a React-based web UI and backend implementations for sub-agent delegation, background execution, session branching, and user interrupts. It also adds documentation for the Agents Middleware. Review feedback correctly identifies documentation errors in the README regarding incorrect and duplicated headers. Additionally, a concurrency issue was noted in the background agent's polling logic, where using setInterval with an asynchronous function could lead to overlapping requests; a recursive setTimeout pattern was recommended as a safer alternative.
| stopPolling(); | ||
| setPollCount(0); | ||
|
|
||
| pollTimerRef.current = setInterval(async () => { |
Contributor
There was a problem hiding this comment.
Using setInterval with an async function can lead to multiple concurrent polling requests if a request takes longer than the interval (2 seconds). It is safer to use a recursive setTimeout pattern to ensure that the next poll only starts after the previous one has completed, preventing potential race conditions or server-side request spikes.
pavelgj
changed the title
Add a new "Trip Planner" agent example that demonstrates defining agents via `.prompt` files (dotprompt) instead of inline code. Includes a new TripPlannerPage in the web UI, backend routes, and suggestion chips in the ChatUI empty state for all agent pages.
Update regex patterns in copyright script to match `.tsx` and `.jsx` file extensions in addition to `.ts` and `.js`, ensuring copyright headers are applied to all TypeScript and JavaScript variants.
Update regex in copyright script to match plain .css files in addition to .scss, and add missing license header to App.css.
Refactor the agents middleware demo to showcase new features: - Per-agent delegation tools instead of a single `call_agent` tool - Auto-discovered agent descriptions from registry metadata - Explicit description overrides via middleware config - `maxDelegations` guard rail and `historyLength` context forwarding - Replace custom `getWebResults` tool with built-in Google Search - Add `retry()` middleware and `maxTurns` to sub-agents
Adds a new coding agent test application featuring: - Coding agent with file read/write, search/replace, and shell tools - TypeScript skill definition for coding conventions - React-based web UI with tool approval workflow - .gitignore entry for agents workspace directory
Switch from InMemorySessionStore to FileSessionStore for session persistence across restarts. Refactor test flow to use agent.run() consistently with other test flows, replacing streamBidi pattern. Auto-approve tool interrupts via the run-based resume API. Fix type cast removal for ctx.metadata and use top-level fs import.
…web app - Rename `Message` interface to `ChatMessage` to avoid conflicts - Replace `any` typed refs and variables with `SessionState`, `MessageData`, `Part`, and `ChatMessage` from genkit/beta - Add missing type imports across all agent page components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent PR: #5252