Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a metadata field to tool definitions, specifically adding a key property derived from the tool's action key. The changes include updates to the toToolDefinition function to populate this metadata and extensive updates across several test files to reflect the new expected structure in tool and prompt-as-tool definitions. I have no feedback to provide.
pavelgj
reviewed
May 8, 2026
| if (originalName !== name) { | ||
| out.metadata = { originalName }; | ||
| const metadata = { | ||
| ...(tool.__action.key ? { key: tool.__action.key } : {}), |
Member
There was a problem hiding this comment.
we talked about adding this to the ToolDefinition, not metadata, no?
genkit/js/ai/src/model-types.ts
Line 115 in 0ee41f9
Collaborator
Author
There was a problem hiding this comment.
We talked about both, I thought we landed back on metadata... I can change it...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (if applicable):