feat(py): Add canonical framework samples for python#5327
Open
huangjeff5 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
docs
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new sample project, flow-sample1, which demonstrates fundamental Genkit framework features in Python, including traced steps, streaming, and error handling. The sample includes various flow implementations and documentation. Feedback suggests removing a redundant string conversion in the parent flow to improve code clarity.
|
|
||
| Demonstrates flow-from-flow: the inner trace nests under the outer one. | ||
| """ | ||
| return str(await basic('foo')) |
Contributor
There was a problem hiding this comment.
The str() call is redundant here because the basic flow is already defined to return a str. Removing it makes the code cleaner and more idiomatic.
Suggested change
| return str(await basic('foo')) | |
| return await basic('foo') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS has a bunch of canonical flows in
flow-sample1to test all core framework features quickly. Adding this to Python as well.