chore(testapp): Add duplicate mcp server to test dev UI handling#5330
chore(testapp): Add duplicate mcp server to test dev UI handling#5330shrutip90 wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces structured logging for policy violations, enables experimental debug traces for the Google AI plugin, and adds a second MCP host to test duplicate tool handling. It also includes a typo fix in a prompt and defines new tools and prompts for file summarization. However, several new prompts and test configurations contain hardcoded absolute paths specific to a local environment, which should be replaced with relative or dynamic paths to ensure portability across different systems.
|
|
||
| {{role "user"}} | ||
|
|
||
| summarize contents of hello-world.txt (in '/Users/padamata/Documents/git/du4/genkit/js/testapps/mcp/test-workspace') |
There was a problem hiding this comment.
This prompt contains a hardcoded absolute path (/Users/padamata/...) which is specific to your local machine. This makes the prompt non-portable and will cause failures on other systems. Consider using a relative path or a template variable.
|
|
||
| {{role "user"}} | ||
|
|
||
| summarize contents of hello-world.txt (in '/Users/padamata/Documents/git/du4/genkit/js/testapps/mcp/test-workspace') No newline at end of file |
There was a problem hiding this comment.
This prompt contains a hardcoded absolute path specific to your local machine. This should be replaced with a portable path reference to ensure it works across different environments.
| tools: ['test-mcp-manager:tool/fs/read_file'], // Just this one tool | ||
| messages: ` | ||
| {{role "user"}} | ||
| Summarize the contents of hello-world.txt (in '/Users/padamata/Documents/git/du4/genkit/js/testapps/mcp/test-workspace')`, |
There was a problem hiding this comment.
Hardcoded absolute path detected. This makes the test app non-portable. Consider using a dynamic path like ${process.cwd()}/test-workspace to ensure it works across different machines.
| tools: ['/dynamic-action-provider/test-mcp-manager:tool/fs/read_file'], // Just this one tool | ||
| messages: ` | ||
| {{role "user"}} | ||
| Summarize the contents of hello-world.txt (in '/Users/padamata/Documents/git/du4/genkit/js/testapps/mcp/test-workspace')`, |
There was a problem hiding this comment.
Hardcoded absolute path detected. This should be replaced with a dynamic or relative path for portability.
1 participant
Description here... Help the reviewer by:
Checklist (if applicable):