Use pluriconfig for parsing servers users request to join #8424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@myleshorton is this PR for moving server parsing logic to radiance? |
Contributor
Author
It's mostly to add functionality, as pluriconfig supports a much broader set of configurations. |
Contributor
Author
* makefile updates to build macos ffi headers * remove unknown target
Contributor
|
I am going to take this spin tomorrow, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/getlantern/engineering/issues/2814
This pull request introduces a new mechanism for adding private servers based on URLs, streamlining the process across the Go backend and Dart frontend. The main change is the addition of a unified
addServerBasedOnURLsmethod, which now takes aserverNameparameter and is exposed through FFI, platform channels, and the application logic. This refactor simplifies server addition, improves code clarity, and enhances maintainability.Backend (Go) changes:
AddServerBasedOnURLsmethod in thePrivateServerinterface and its implementations to accept aserverNameparameter, ensuring the server can be identified by name when added. [1] [2] [3]addServerBasedOnURLsto expose this functionality to other platforms, handling the newserverNameparameter.Frontend (Dart) changes:
addServerBasedOnURLsmethod inLanternCoreServiceand implemented it in bothLanternFFIServiceandLanternPlatformService, passing through the new parameters. [1] [2] [3] [4]PrivateServerNotifierand UI logic to use the newaddServerBasedOnURLsmethod, replacing the previous manual server addition flow and simplifying the join process in the UI. [1] [2]These changes collectively modernize and unify the process of adding private servers by URL, making the codebase easier to maintain and extend.