Skip to content

ref(chat)!: remove per-Turn publish choice - #1736

Draft
dcramer wants to merge 1 commit into
mainfrom
codex/store-publish-on-turn
Draft

ref(chat)!: remove per-Turn publish choice#1736
dcramer wants to merge 1 commit into
mainfrom
codex/store-publish-on-turn

Conversation

@dcramer

@dcramer dcramer commented Aug 29, 2026

Copy link
Copy Markdown
Member

Assistant output no longer carries a per-message or per-Turn publish choice. Slack input always delivers to Slack. Web and local input stay in Junior. Resource events deliver from the Conversation Location. Scheduled tasks, Event tasks, and plugin dispatches get Delivery for their explicit Destination. Agent invocations stay internal. Mailbox batches also stay within one Actor and Source.

This is a hard cutover for the internal Inbound message, worker, Turn checkpoint, and AgentRun contracts. Redis mailbox and Turn cursor records still write publishExternally for deployed readers during rollout, but current workers ignore it. Both writes have removal TODOs.

The shared web and Resource event worker still uses Run Delivery to store each completed assistant Message. It temporarily checks Resource event Source before it also calls Slack. Its TODO removes that check after core Turn storage is independent and each work owner supplies optional Delivery. The current Slack dispatch path has a separate TODO to stop creating a synthetic Message and Thread.

Refs #1563

@vercel

vercel Bot commented Aug 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
junior-docs Ready Ready Preview Aug 29, 2026 8:15am

Request Review

@dcramer
dcramer force-pushed the codex/store-publish-on-turn branch from e0928c0 to f0be9d2 Compare August 29, 2026 05:16
@dcramer dcramer changed the title ref(chat)!: store publish on mailbox input and Turns ref(chat)!: deliver from Conversation Location Aug 29, 2026
@dcramer
dcramer force-pushed the codex/store-publish-on-turn branch from f0be9d2 to fcd6fc7 Compare August 29, 2026 05:19
Comment thread packages/junior/src/chat/task-execution/conversation-turn.ts Outdated
@dcramer
dcramer force-pushed the codex/store-publish-on-turn branch from fcd6fc7 to 1968ba5 Compare August 29, 2026 06:15
@dcramer dcramer changed the title ref(chat)!: deliver from Conversation Location ref(chat)!: remove per-Turn publish choice Aug 29, 2026
@dcramer
dcramer force-pushed the codex/store-publish-on-turn branch from 1968ba5 to 7027551 Compare August 29, 2026 06:40

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7027551. Configure here.

Comment thread packages/junior/src/chat/task-execution/conversation-turn.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant