Skip to content

test(quartz3): add MonitorAllJobs and ExcludedJobs to API snapshots - #5832

Merged
ric-oliv merged 1 commit into
mainfrom
ai/main-branch-failures-e897be
Oct 30, 2026
Merged

ric-oliv merged 1 commit into
mainfrom
ai/main-branch-failures-e897be

Conversation

@jamescrosswell

Copy link
Copy Markdown
Collaborator

Fixes the ApiApprovalTests.Run failures in Sentry.Quartz3.Tests that are currently failing every .NET build job on main.

#5741 added MonitorAllJobs and ExcludedJobs to SentryQuartzOptions. #5668 added Sentry.Quartz3, which compiles the same source but has its own API snapshots, written before those options existed. Each PR was green on its own; the combination wasn't.

#skip-changelog

🤖 Generated with Claude Code

#5741 added these options to SentryQuartzOptions, and #5668 added
Sentry.Quartz3 (which compiles the same source) with snapshots that
predate them. Each PR was green on its own; together they broke main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.37%. Comparing base (fe691cc) to head (97fdcf4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5832      +/-   ##
==========================================
+ Coverage   76.36%   76.37%   +0.01%     
==========================================
  Files         528      530       +2     
  Lines       19557    19608      +51     
  Branches     3825     3854      +29     
==========================================
+ Hits        14934    14976      +42     
- Misses       3741     3748       +7     
- Partials      882      884       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jamescrosswell
jamescrosswell marked this pull request as ready for review October 29, 2026 23:48
@github-actions github-actions Bot added the risk: low PR risk score: low label Oct 29, 2026

@ric-oliv ric-oliv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ric-oliv
ric-oliv merged commit d4a1de1 into main Oct 30, 2026
48 checks passed
@ric-oliv
ric-oliv deleted the ai/main-branch-failures-e897be branch October 30, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: low PR risk score: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants