Repository navigation
chore: Remove unused vendored Force.Crc32 - #5854
Merged
Merged
Conversation
Its only caller was MetricAggregator's string hashing for Metrics.Set, which was removed with the deprecated Metrics API in #3718.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5854 +/- ##
==========================================
+ Coverage 76.37% 76.70% +0.33%
==========================================
Files 530 528 -2
Lines 19608 19527 -81
Branches 3854 3840 -14
==========================================
+ Hits 14975 14978 +3
+ Misses 3749 3665 -84
Partials 884 884 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jamescrosswell
marked this pull request as ready for review
November 2, 2026 08:09
jamescrosswell
requested review from
jamescrosswell and
ric-oliv
as code owners
November 2, 2026 08:09
jamescrosswell
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
src/Sentry/Force.Crc32/, the copy of force-net'sCrc32.NETvendored into the core package (Sentry.Force.Crc32.Crc32Algorithm,Sentry.Force.Crc32.SafeProxy, plus its LICENSE and README; 304 lines). Nothing uses it.When it was added: #3092 (
feat: Metrics.Set now accepts string as value, merged 2024-01-30).MetricAggregatorusedCrc32Algorithm.Compute(Encoding.UTF8.GetBytes(value))to hash string values forMetrics.Set.When it became irrelevant, and why: #3718 (
Removed Metrics (deprecated), merged 2024-10-30 intoversion-5.0.0, shipped in 5.0.0 on 2024-12-19) deletedsrc/Sentry/MetricAggregator.cs, which held the only call. The vendored files weren't part of that PR, so they stayed behind. The only commit to touch them since #3092 is the formatting pass in #3097.Evidence it's unused:
modules/forCrc32Algorithm,SafeProxy,Sentry.ForceorCrc32.NETfinds only the deleted files. TheGzipCrc32in the Android assembly reader's ELFSharp code is a separate implementation.MetricHelperetc.) doesn't hash with CRC32.Why it's safe: every type is
internal, so there's no public API change and the API approval snapshots don't change. Nothing constructed it, so runtime behavior doesn't change. No target framework or package dependency changes.Checks:
dotnet build src/Sentry/Sentry.csproj -c Releasepasses for net8.0, net9.0, net10.0, netstandard2.0, netstandard2.1 and net462, with no warnings.Sentry.Testson net10.0: 2,697 passed, 0 failed, 5 skipped. No snapshot changes.workloadVersionfromglobal.jsonfor the local build only. That change isn't committed.#skip-changelog
via automation
sched_2fb5d12bd3a78841d7d2559c56e8141d· Run IDsched_2fb5d12bd3a78841d7d2559c56e8141d:1793602800000.--
View Session [Sentry]