Repository navigation
fix(v10/nextjs): Include basePath in request url of Pages Router errors - #25064
Merged
chargome merged 2 commits intoOct 6, 2026
Merged
Conversation
Contributor
size-limit report 📦
|
…sePath e2e v10 does not stream spans by default, so the server request is sent as a transaction rather than a streamed segment span. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
approved these changes
Oct 6, 2026
chargome
marked this pull request as ready for review
October 6, 2026 08:14
chargome
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
October 6, 2026 08:14
nicohrubec
approved these changes
Oct 6, 2026
chargome
deleted the
backport/v10-nextjs-pages-router-basepath-request-url
branch
October 6, 2026 08:24
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #24985
Differences to the original PR
packages/nextjs/src/common/pages-router-instrumentation/wrapApiHandlerWithSentry.ts: v10 still has the older API route wrapper that starts its ownhttp.serverspan, so the swap topagesRouterRequestToRequestDatalands on thenormalizedRequestused there instead of the inlinesetSDKProcessingMetadatacall. Because that span buildsurl.fullandurl.pathfrom the same request data, on v10 those span attributes also include thebasePathnow.dev-packages/e2e-tests/test-applications/nextjs-15-basepath/tests/pages-router-request-url.test.ts: v10 does not stream spans by default, so the tests wait for thehttp.servertransaction and check itsrequest.urlinstead of the streamed segment span'surl.full. The transaction'srequest.urlhas no query string (it is inquery_string), so the assertion leaves it out.