Repository navigation
Conversation
…sbuild plugins Move the four wrapper packages from sentry-javascript-bundler-plugins into packages/legacy. Each one re-exports the matching @sentry/bundler-plugins subpath and now releases in lockstep with the SDK.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
size-limit report 📦
|
| TARBALL_ARTIFACT_GLOB: packages/*/*.tgz | ||
| TARBALL_ARTIFACT_GLOB: | | ||
| packages/*/*.tgz | ||
| packages/legacy/*/*.tgz |
There was a problem hiding this comment.
Legacy tarballs restore to wrong path
Medium Severity
The new packages/legacy/*/*.tgz upload glob is stripped through the first *, so restored artifacts land at packages/esbuild-plugin/*.tgz (and the other plugin folders) instead of packages/legacy/<pkg>/*.tgz. Downstream jobs that look for tarballs beside each package will miss the new wrappers.
Reviewed by Cursor Bugbot for commit d1a1537. Configure here.
| it('re-exports the default export', () => { | ||
| expect(plugin.default).toBe(bundlerPlugins.default); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Feat lacks integration or E2E tests
Low Severity
This feat only adds unit tests that compare re-exported keys. There is no integration or E2E coverage of the published wrapper packages. Existing e2e apps still pin @sentry/vite-plugin and @sentry/rollup-plugin at ^5.3.0, and packed-tarball discovery only scans packages/*/package.json, so it never picks up packages/legacy/*. Flagged because this was mentioned in the review rules.
Additional Locations (2)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit d1a1537. Configure here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 563d2fc. Configure here.
| "packages/legacy/esbuild-plugin", | ||
| "packages/legacy/rollup-plugin", | ||
| "packages/legacy/vite-plugin", | ||
| "packages/legacy/webpack-plugin", |
There was a problem hiding this comment.
E2E misses nested plugin tarballs
Medium Severity
The new wrappers live under packages/legacy/, but E2E tarball discovery still globs only packages/*/package.json and packages/*/*.tgz. Existing apps that depend on @sentry/vite-plugin and @sentry/rollup-plugin will keep installing the published 5.x packages from npm instead of the in-repo 11.x wrappers, and a pnpm.overrides pin of @sentry/bundler-plugins@11.x can be applied on top of those old plugins.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 563d2fc. Configure here.
This branch has not been deployed
1 participant
Move the four wrapper packages from
sentry-javascript-bundler-pluginsintopackages/legacy. Each one re-exports the matching@sentry/bundler-pluginssubpath and now releases in lockstep with the SDK.