Repository navigation
ref(eslint-plugin-sdk): Improve no-unsafe-random-apis rule - #25123
Merged
Merged
Conversation
The rule only matched calls whose callee was a plain `Identifier.prop` member expression. That missed `crypto.randomUUID!()`, TS casts, access through a global object like `globalThis.performance.now()`, and code that passes the function around (`const now = performance.now`, `.bind`, destructuring) so it can be called outside the wrapper. Also accept `_INTERNAL_withRandomSafeContext` as a wrapper and drop the stale `safeRandomGeneratorRunner` file skip. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Lms24
changed the title
no-unsafe-random-apis rule
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3eaf077. Configure here.
Only catch calls of the unsafe APIs. Flagging `new globalThis.Date()`, function references and destructuring is overkill, and nothing in the codebase uses those shapes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Came up in #24903 (comment). This PR makes the
no-unsafe-random-apisrule a bit more robust. We now catch:crypto.randomUUID!()and TS casts (as,satisfies,<T>)performance?.now(),crypto?.randomUUID?.()globalThis.performance.now(),GLOBAL_OBJ.crypto.randomUUID(),WINDOW.performance?.now()