Skip to content

ref(core): Simplify transport item loss recording - #25224

Merged
Lms24 merged 2 commits into
developfrom
lms/ref-core-simplify-transport-event-drop-report
Oct 9, 2026
Merged

Lms24 merged 2 commits into
developfrom
lms/ref-core-simplify-transport-event-drop-report

Conversation

@Lms24

@Lms24 Lms24 commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Realized a second after merging #25185 that the report logic can be simplified to save a few bytes.

@Lms24

Lms24 commented Oct 9, 2026

Copy link
Copy Markdown
Member Author

bugbot review

@Lms24 Lms24 self-assigned this Oct 9, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 973a002. Configure here.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 29.82 kB -0.03% -8 B 🔽
@sentry/browser - with treeshaking flags 27.96 kB -0.04% -10 B 🔽
@sentry/browser - with treeshaking flags tracing without tracing 27.87 kB -0.04% -9 B 🔽
@sentry/browser (incl. Tracing) 51.89 kB -0.02% -10 B 🔽
@sentry/browser (incl. Tracing + Span Streaming) 51.91 kB -0.02% -9 B 🔽
@sentry/browser (incl. Tracing, Profiling) 54.84 kB -0.02% -10 B 🔽
@sentry/browser (incl. Tracing, Replay) 91.64 kB -0.01% -4 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 80.51 kB -0.02% -11 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 96.36 kB -0.01% -4 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 109.34 kB -0.01% -5 B 🔽
@sentry/browser (incl. Feedback) 47.35 kB -0.02% -8 B 🔽
@sentry/browser (incl. sendFeedback) 34.87 kB -0.03% -9 B 🔽
@sentry/browser (incl. FeedbackAsync) 39.98 kB -0.03% -10 B 🔽
@sentry/browser (incl. Metrics) 30.85 kB -0.03% -9 B 🔽
@sentry/browser (incl. Logs) 31.14 kB -0.04% -10 B 🔽
@sentry/browser (incl. Metrics & Logs) 31.78 kB -0.03% -8 B 🔽
@sentry/react 31.66 kB -0.04% -11 B 🔽
@sentry/react (incl. Tracing) 54.22 kB -0.02% -8 B 🔽
@sentry/vue 37.89 kB -0.03% -10 B 🔽
@sentry/vue (incl. Tracing) 54.81 kB -0.03% -16 B 🔽
@sentry/svelte 29.85 kB -0.05% -12 B 🔽
@sentry/remix (Remix 3 client bundle) 56.88 kB -0.02% -6 B 🔽
CDN Bundle 31.57 kB -0.03% -8 B 🔽
CDN Bundle (incl. Tracing) 52.4 kB -0.02% -9 B 🔽
CDN Bundle (incl. Logs, Metrics) 33.76 kB -0.04% -11 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) 54.35 kB -0.01% -5 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) 74.68 kB -0.02% -12 B 🔽
CDN Bundle (incl. Tracing, Replay) 90.07 kB -0.01% -7 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 92.01 kB -0.01% -5 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 96.23 kB -0.01% -4 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 98.2 kB -0.01% -4 B 🔽
CDN Bundle - uncompressed 93.05 kB -0.03% -27 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 155.64 kB -0.02% -27 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed 99.59 kB -0.03% -27 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 161.59 kB -0.02% -27 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 229.63 kB -0.02% -27 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 275.8 kB -0.01% -27 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 281.74 kB -0.01% -27 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 289.51 kB -0.01% -27 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 295.44 kB -0.01% -27 B 🔽
@sentry/nextjs (client) 56.59 kB -0.03% -13 B 🔽
@sentry/sveltekit (client) 52.27 kB -0.02% -10 B 🔽
@sentry/core/server 40.87 kB - -
@sentry/core/browser 13.73 kB - -
@sentry/node 151.69 kB -0.01% -2 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection) 83.77 kB - -
@sentry/node - without tracing 94.25 kB +0.01% +4 B 🔺
@sentry/node - without channel injection 129.86 kB -0.01% -2 B 🔽
@sentry/aws-serverless 102.42 kB -0.01% -6 B 🔽
@sentry/cloudflare (withSentry) - minified 210.01 kB -0.02% -27 B 🔽
@sentry/cloudflare (withSentry) 520.66 kB -0.02% -71 B 🔽
@sentry/nextjs/cloudflare (withSentry) - minified 227.68 kB -0.02% -27 B 🔽

View base workflow run

@Lms24
Lms24 marked this pull request as ready for review October 9, 2026 11:16
@Lms24
Lms24 requested a review from chargome October 9, 2026 11:16
@Lms24
Lms24 enabled auto-merge (squash) October 9, 2026 12:11
@Lms24
Lms24 merged commit 072b269 into develop Oct 9, 2026
705 of 707 checks passed
@Lms24
Lms24 deleted the lms/ref-core-simplify-transport-event-drop-report branch October 9, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants