Skip to content

chore(deps): update CLI to v3.5.1 #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update CLI to v3.5.1 #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## Unreleased

### Dependencies

- Bump CLI from v3.3.0 to v3.5.1 ([#259](https://github.com/getsentry/sentry-maven-plugin/pull/259))
- [changelog](https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md#351)
- [diff](https://github.com/getsentry/sentry-cli/compare/3.3.0...3.5.1)

## 0.11.0

### Features
Expand Down
2 changes: 1 addition & 1 deletion sentry-cli.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
version = 3.3.0
version = 3.5.1
repo = https://github.com/getsentry/sentry-cli

@sentry sentry Bot Jun 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The download-sentry-cli.sh script lacks error handling for curl downloads. If a binary is missing for a platform, an invalid file is created, causing later build failures.
Severity: MEDIUM

Suggested Fix

Add the -f or --fail flag to the curl commands in download-sentry-cli.sh. This will cause curl to exit with a non-zero status code on HTTP errors (like 404 Not Found), which will then fail the build script as intended by failonerror="true" in the pom.xml.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: sentry-cli.properties#L2

Potential issue: The `download-sentry-cli.sh` script uses `curl -SL` without the `-f`
flag to download `sentry-cli` binaries. If a binary for a specific platform (e.g.,
32-bit Windows or Linux) is not available for the new version 3.5.1, `curl` will still
exit successfully, creating an empty or invalid file. The build process does not
validate the downloaded files. This will lead to build failures on those platforms when
they attempt to execute the corrupted binary. Since CI only tests 64-bit platforms, this
issue would not be caught before merging.

Did we get this right? 👍 / 👎 to inform future reviews.