Skip to content

test(e2e): Widen WebView demo-page trace poll window to de-flake e2e #6950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 1 commit into from
Oct 29, 2026
Merged

test(e2e): Widen WebView demo-page trace poll window to de-flake e2e #6950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions samples/react-native/src/Screens/WebviewScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,15 @@ function buildDemoPage(dsn: string): string {
<p>Injected <code>sentry-trace</code>:</p>
<pre id="trace" style="white-space: pre-wrap; word-break: break-all;">(reading…)</pre>
<script>
// On Android the injected script runs slightly after this page's initial
// script, so poll briefly for the meta tag. A real app's @sentry/browser reads
// it during pageload init (which happens later), so it doesn't need this.
// On Android the injected script runs asynchronously, slightly after this
// page's initial script, so poll for the meta tag. The window is generous
// (20s) because a cold-start release build on a slow CI emulator can inject
// noticeably later than on a local device — a shorter window intermittently
// declared the trace "not injected" before it landed, flaking the e2e test.
// It stays within the e2e's 30s wait on the connected status. A real app's
// @sentry/browser reads the tag during pageload init, so it doesn't need this.
var tries = 0;
var maxTries = 200; // 200 * 100ms = 20s
function report() {
var trace = document.querySelector('meta[name="sentry-trace"]');
var baggage = document.querySelector('meta[name="baggage"]');
Expand All @@ -64,9 +69,9 @@ function buildDemoPage(dsn: string): string {
if (!report()) {
var iv = setInterval(function () {
tries++;
if (report() || tries > 30) {
if (report() || tries >= maxTries) {
clearInterval(iv);
if (tries > 30) document.getElementById('trace').textContent = '(none — not injected)';
if (tries >= maxTries) document.getElementById('trace').textContent = '(none — not injected)';
}
}, 100);
}
Expand Down
Loading