Repository navigation
fix(ios): Honor Sentry.Mask in error screenshots - #6974
Merged
Merged
Conversation
Register RNSentryReplayMask as a masked view class for screenshots so <Sentry.Mask> is masked in JS error screenshots, the same as in Session Replay. The native SDK only lets hybrid SDKs set the mask container class on the replay photographer, not the screenshot one. Fixes #6970 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7218536. Configure here.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
📲 Install BuildsAndroid
|
antonis
marked this pull request as ready for review
October 30, 2026 07:25
antonis
requested review from
alwx and
buenaflor
and removed request for
a team
October 30, 2026 07:25
alwx
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR adds
RNSentryReplayMasktooptions.screenshot.maskedViewClassesinRNSentryStart. The whole wrapper is masked, which covers its children the same way the replay mask container does. AnymaskedViewClassesthe user passes are kept.💡 Motivation and Context
Fixes #6970
💚 How did you test it?
RNSentryStartTestscases📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps