ref(preprod): Rename projectId to projectSlug

static/app/views/preprod/buildDetails/buildDetails.tsx

@@ -113,7 +113,7 @@ export default function BuildDetails() {
         <Layout.Header>
           <BuildDetailsHeaderContent
             buildDetailsQuery={buildDetailsQuery}
-            projectId={projectId}
+            projectSlug={projectId}
             artifactId={artifactId}
           />
         </Layout.Header>
@@ -125,7 +125,7 @@ export default function BuildDetails() {
                 buildDetailsData={buildDetailsQuery.data}
                 isBuildDetailsPending={buildDetailsQuery.isPending}
                 artifactId={artifactId}
-                projectId={projectId}
+                projectSlug={projectId}
               />
             </BuildDetailsSide>
             <BuildDetailsMain>

static/app/views/preprod/buildDetails/header/buildDetailsHeaderContent.tsx

@@ -19,18 +19,18 @@ import {createActionMenuItems} from './buildDetailsActionItems';
 import {useBuildDetailsActions} from './useBuildDetailsActions';
 
 function makeReleasesUrl(
-  projectId: string | undefined,
+  projectSlug: string | undefined,
   query: {appId?: string; version?: string}
 ): string {
   const {appId, version} = query;
 
-  // Not knowing the projectId should be transient.
-  if (projectId === undefined) {
+  // Not knowing the projectSlug should be transient.
+  if (projectSlug === undefined) {
     return '#';
   }
 
   const params = new URLSearchParams();
-  params.set('project', projectId);
+  params.set('project', projectSlug);
   const parts = [];
   if (appId) {
     parts.push(`release.package:${appId}`);
@@ -47,16 +47,16 @@ function makeReleasesUrl(
 interface BuildDetailsHeaderContentProps {
   artifactId: string;
   buildDetailsQuery: UseApiQueryResult<BuildDetailsApiResponse, RequestError>;
-  projectId: string;
+  projectSlug: string;
 }
 
 export function BuildDetailsHeaderContent(props: BuildDetailsHeaderContentProps) {
   const organization = useOrganization();
   const isSentryEmployee = useIsSentryEmployee();
-  const {buildDetailsQuery, projectId, artifactId} = props;
+  const {buildDetailsQuery, projectSlug, artifactId} = props;
   const {isDeletingArtifact, handleDeleteAction, handleDownloadAction} =
     useBuildDetailsActions({
-      projectId,
+      projectSlug,
       artifactId,
     });
 
@@ -84,7 +84,7 @@ export function BuildDetailsHeaderContent(props: BuildDetailsHeaderContentProps)
     );
   }
 
-  const project = ProjectsStore.getBySlug(projectId);
+  const project = ProjectsStore.getBySlug(projectSlug);
 
   const breadcrumbs: Crumb[] = [
     {
@@ -124,7 +124,7 @@ export function BuildDetailsHeaderContent(props: BuildDetailsHeaderContentProps)
         </Heading>
         <Flex align="center" gap="sm" flexShrink={0}>
           <Link
-            to={`/organizations/${organization.slug}/preprod/${projectId}/compare/${buildDetailsData.id}/`}
+            to={`/organizations/${organization.slug}/preprod/${projectSlug}/compare/${buildDetailsData.id}/`}
           >
             <Button size="sm" priority="default" icon={<IconTelescope />}>
               {t('Compare Build')}

static/app/views/preprod/buildDetails/header/useBuildDetailsActions.tsx

@@ -9,11 +9,11 @@ import useOrganization from 'sentry/utils/useOrganization';
 
 interface UseBuildDetailsActionsProps {
   artifactId: string;
-  projectId: string;
+  projectSlug: string;
 }
 
 export function useBuildDetailsActions({
-  projectId,
+  projectSlug,
   artifactId,
 }: UseBuildDetailsActionsProps) {
   const organization = useOrganization();
@@ -25,14 +25,14 @@ export function useBuildDetailsActions({
   >({
     mutationFn: () => {
       return fetchMutation({
-        url: `/projects/${organization.slug}/${projectId}/preprodartifacts/${artifactId}/delete/`,
+        url: `/projects/${organization.slug}/${projectSlug}/preprodartifacts/${artifactId}/delete/`,
         method: 'DELETE',
       });
     },
     onSuccess: () => {
       addSuccessMessage(t('Build deleted successfully'));
       // TODO(preprod): navigate back to the release page once built?
-      navigate(`/organizations/${organization.slug}/preprod/${projectId}/`);
+      navigate(`/organizations/${organization.slug}/preprod/${projectSlug}/`);
     },
     onError: () => {
       addErrorMessage(t('Failed to delete build'));
@@ -53,7 +53,7 @@ export function useBuildDetailsActions({
   };
 
   const handleDownloadAction = async () => {
-    const downloadUrl = `/api/0/internal/${organization.slug}/${projectId}/files/preprodartifacts/${artifactId}/`;
+    const downloadUrl = `/api/0/internal/${organization.slug}/${projectSlug}/files/preprodartifacts/${artifactId}/`;
 
     try {
       const response = await fetch(downloadUrl, {

static/app/views/preprod/buildDetails/sidebar/buildDetailsSidebarAppInfo.tsx

@@ -65,7 +65,7 @@ function getLabels(platform: Platform | undefined): Labels {
 interface BuildDetailsSidebarAppInfoProps {
   appInfo: BuildDetailsAppInfo;
   artifactId: string;
-  projectId: string | null;
+  projectSlug?: string;
   sizeInfo?: BuildDetailsSizeInfo;
 }
 
@@ -157,10 +157,10 @@ export function BuildDetailsSidebarAppInfo(props: BuildDetailsSidebarAppInfoProp
             <IconLink />
           </InfoIcon>
           <Text>
-            {props.projectId && props.appInfo.is_installable ? (
+            {props.projectSlug && props.appInfo.is_installable ? (
               <InstallableLink
                 onClick={() => {
-                  openInstallModal(props.projectId!, props.artifactId);
+                  openInstallModal(props.projectSlug!, props.artifactId);
                 }}
               >
                 Installable

static/app/views/preprod/buildDetails/sidebar/buildDetailsSidebarContent.spec.tsx

@@ -36,19 +36,19 @@ const mockBuildDetailsData: BuildDetailsApiResponse = {
 
 function TestComponent({
   artifactId,
-  projectId,
+  projectSlug,
   buildDetailsData,
   isBuildDetailsPending,
 }: {
   artifactId: string;
-  projectId: string;
-  buildDetailsData?: BuildDetailsApiResponse | null;
+  projectSlug: string;
+  buildDetailsData?: BuildDetailsApiResponse;
   isBuildDetailsPending?: boolean;
 }) {
   return (
     <BuildDetailsSidebarContent
       artifactId={artifactId}
-      projectId={projectId}
+      projectSlug={projectSlug}
       buildDetailsData={buildDetailsData}
       isBuildDetailsPending={isBuildDetailsPending}
     />
@@ -62,7 +62,7 @@ describe('BuildDetailsSidebarContent', () => {
 
   const defaultProps = {
     artifactId: '123',
-    projectId: 'test-project',
+    projectSlug: 'test-project',
   };
 
   beforeEach(() => {

static/app/views/preprod/buildDetails/sidebar/buildDetailsSidebarContent.tsx

@@ -20,13 +20,18 @@ import {
 
 interface BuildDetailsSidebarContentProps {
   artifactId: string;
-  projectId: string | null;
-  buildDetailsData?: BuildDetailsApiResponse | null;
+  buildDetailsData?: BuildDetailsApiResponse;
   isBuildDetailsPending?: boolean;
+  projectSlug?: string;
 }
 
 export function BuildDetailsSidebarContent(props: BuildDetailsSidebarContentProps) {
-  const {buildDetailsData, isBuildDetailsPending = false, artifactId, projectId} = props;
+  const {
+    buildDetailsData,
+    isBuildDetailsPending = false,
+    artifactId,
+    projectSlug,
+  } = props;
 
   if (isBuildDetailsPending || !buildDetailsData) {
     return <SidebarLoadingSkeleton data-testid="sidebar-loading-skeleton" />;
@@ -126,7 +131,7 @@ export function BuildDetailsSidebarContent(props: BuildDetailsSidebarContentProp
         <BuildDetailsSidebarAppInfo
           appInfo={buildDetailsData.app_info}
           sizeInfo={buildDetailsData.size_info}
-          projectId={projectId}
+          projectSlug={projectSlug}
           artifactId={artifactId}
         />
       )}

static/app/views/pullRequest/details/main/pullRequestDetailsSizeContent.tsx

@@ -90,7 +90,7 @@ export function PullRequestDetailsSizeContent({
             <BuildDetailsSidebarContent
               buildDetailsData={selectedBuildDetail}
               artifactId={selectedBuildId}
-              projectId={null}
+              projectSlug={undefined}
             />
           )}
         </Flex>