feat(issues): GA empty tag values #103097
Open
+78
−171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables empty tag values flag by default. Displays "(empty)" when a specific tag was omitted from some number of events within a group.
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #103097 +/- ##
============================================
+ Coverage 66.27% 80.63% +14.35%
============================================
Files 9217 9207 -10
Lines 393473 393466 -7
Branches 25104 24982 -122
============================================
+ Hits 260792 317254 +56462
+ Misses 132233 75786 -56447
+ Partials 448 426 -22 |
scttcper
commented
Nov 12, 2025
Comment on lines
+211
to
+213
| has_non_empty_value = any(value != "" for value in result.keys()) | ||
| if not has_non_empty_value: | ||
| raise TagKeyNotFound if group is None else GroupTagKeyNotFound |
Member
Author
There was a problem hiding this comment.
this is the only real change that was breaking some tests. I think they're requesting specific tags and we want to throw if they're not found?
cvxluo
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables empty tag values flag by default. Displays "(empty)" when a specific tag was omitted from some number of events within a group.