feat(ai-grouping): add secondary stacktrace filtering by token count #103106
+133
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking stacktrace frame count we now add a secondary check for stacktraces which pass the frame count to also filter by token count. This is a first step towards moving to token count only.
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #103106 +/- ##
===========================================
+ Coverage 79.79% 80.68% +0.88%
===========================================
Files 9200 9206 +6
Lines 392932 393318 +386
Branches 24992 24992
===========================================
+ Hits 313546 317354 +3808
+ Misses 78960 75538 -3422
Partials 426 426 |
shashjar
reviewed
Nov 10, 2025
src/sentry/seer/similarity/utils.py
Outdated
| "grouping.similarity.frame_count_filter", | ||
| "grouping.similarity.stacktrace_length_filter", | ||
| sample_rate=options.get("seer.similarity.metrics_sample_rate"), | ||
| tags={**shared_tags, "outcome": "block"}, |
Member
There was a problem hiding this comment.
Should we update this outcome to block_by_frame_count or something like that?
Member
There was a problem hiding this comment.
Same in the call to report_token_count_metric
Member
Author
There was a problem hiding this comment.
oh yea for sure I want to differentiate between the two, not even a nit this is a real oversight, thanks 👍
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking stacktrace frame count we now add a secondary check for stacktraces which pass the frame count to also filter by token count. This is a first step towards moving to token count only.