fix(replay): Add fallback ordering to replay index page #103328
Merged
+44
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #103328 +/- ##
===========================================
- Coverage 80.67% 80.67% -0.01%
===========================================
Files 9237 9237
Lines 394583 394577 -6
Branches 25146 25146
===========================================
- Hits 318345 318339 -6
Misses 75791 75791
Partials 447 447 |
srest2021
commented
Nov 14, 2025
| config: dict[str, Expression], sort: str, tiebreaker: str | None = None | ||
| ) -> list[OrderBy]: | ||
| direction = Direction.DESC if sort.startswith("-") else Direction.ASC | ||
| bare_sort = sort[1:] if sort.startswith("-") else sort |
Member
Author
There was a problem hiding this comment.
could also use sort.lstrip("-")
michellewzhang
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes REPLAY-830
In the replay index page, when sorting by columns that contain duplicate values (e.g., startedAt, duration, countErrors), the order of rows with identical values is non-deterministic, which results in inconsistent pagination. Let's add a fallback ordering on replay_id. We are already grouping by replay_id so the fallback sort will operate on the aggregated results.