Skip to content

feat(issue-details): Add config for hiding grouping info #103351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2025
+10 −1
Merged

feat(issue-details): Add config for hiding grouping info #103351

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f20de1a
feat(issue-details): Add config for hiding grouping info
malwilley Nov 14, 2025
f9ff4f3
Merge branch 'master' into malwilley/feat/add-config-for-hiding-group…
malwilley Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions static/app/utils/issueTypeConfig/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ const BASE_CONFIG: IssueTypeConfig = {
usesIssuePlatform: true,
issueSummary: {enabled: false},
useOpenPeriodChecks: false,
groupingInfo: {enabled: true},
};

const issueTypeConfig: Config = {
Expand Down
1 change: 1 addition & 0 deletions static/app/utils/issueTypeConfig/metricConfig.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ const metricConfig: IssueCategoryConfigMapping = {
stats: {enabled: true},
tags: {enabled: false},
issueSummary: {enabled: false},
groupingInfo: {enabled: false},
Copy link
Contributor

@cursor cursor bot Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Regression Issues: Grouping Info Display Bug

groupingInfo: {enabled: false} is only set for IssueType.METRIC_ISSUE, but not for IssueType.PERFORMANCE_ENDPOINT_REGRESSION and IssueType.PROFILE_FUNCTION_REGRESSION. These regression issue types also don't go through traditional grouping (similar to metric issues), so they will incorrectly show grouping information. The fix should move this config to _categoryDefaults to apply to all metric category issues, matching the pattern used in outageConfig.

Fix in Cursor Fix in Web

},
};

Expand Down
1 change: 1 addition & 0 deletions static/app/utils/issueTypeConfig/outageConfig.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const outageConfig: IssueCategoryConfigMapping = {
mergedIssues: {enabled: false},
similarIssues: {enabled: false},
issueSummary: {enabled: false},
groupingInfo: {enabled: false},
},
[IssueType.MONITOR_CHECK_IN_FAILURE]: {
actions: {
Expand Down
6 changes: 6 additions & 0 deletions static/app/utils/issueTypeConfig/types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,12 @@ export type IssueTypeConfig = {
title: string;
helpText?: string;
} | null;
/**
* Should the grouping information section be shown within the event details?
* Some issue types are grouped by some user defined object like a metric or uptime detector,
* so in those cases it doesn't make sense to show this.
*/
groupingInfo: DisabledWithReasonConfig;
/**
* Configuration for the issue-level information header
*/
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/issueDetails/groupEventDetails/groupEventDetailsContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ export function EventDetailsContent({
/>
</EntryErrorBoundary>
)}
{event.groupID && (
{event.groupID && issueTypeConfig.groupingInfo.enabled && (
<EventGroupingInfoSection
projectSlug={project.slug}
event={event}
Expand Down
Loading