fix(replay): validate replay start/end for summaries

[michellewzhang]

fixeds SENTRY-5CYF

if replay start or replay end are missing, pass None instead of a empty string

[aliu39]

lets pass None when missing, seer accepts none now

could also leave it as is and keep observing when this happens, we're selecting all fields in query_replay_instance so I'd expect these to always be valid

[michellewzhang]

lets pass None when missing, seer accepts none now

could also leave it as is and keep observing when this happens, we're selecting all fields in query_replay_instance so I'd expect these to always be valid

pass None as the replay_start/replay_end value?

[aliu39]

can we add a warning log for when either is none, it really shouldn't happen for the snuba query

[michellewzhang]

confused why we were converting from iso and then to iso here, do we need this? .get() should default to None if it doesn't find anything

[aliu39]

doing fromiso first to validate the format.

[michellewzhang]

ok added back validation

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...sentry/replays/endpoints/project_replay_summary.py	66.66%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #103388      +/-   ##
===========================================
+ Coverage   80.64%    80.67%   +0.03%     
===========================================
  Files        9237      9237              
  Lines      394659    394658       -1     
  Branches    25146     25146              
===========================================
+ Hits       318280    318407     +127     
+ Misses      75932     75804     -128     
  Partials      447       447