Skip to content

test(issues): Migrate issue details components away from deprecatedRouterMocks #103699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2025
+79 −46
Merged

test(issues): Migrate issue details components away from deprecatedRouterMocks #103699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions static/app/views/issueDetails/groupSimilarIssues/similarIssuesDrawer.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
import {GroupFixture} from 'sentry-fixture/group';
import {OrganizationFixture} from 'sentry-fixture/organization';
import {ProjectFixture} from 'sentry-fixture/project';
import {RouterFixture} from 'sentry-fixture/routerFixture';

import {render, screen, waitFor} from 'sentry-test/reactTestingLibrary';
import {
render,
screen,
waitFor,
type RouterConfig,
} from 'sentry-test/reactTestingLibrary';

import GroupStore from 'sentry/stores/groupStore';
import ProjectsStore from 'sentry/stores/projectsStore';
Expand All @@ -13,9 +17,12 @@ describe('SimilarIssuesDrawer', () => {
const organization = OrganizationFixture();
const project = ProjectFixture({features: ['similarity-view']});
const group = GroupFixture();
const router = RouterFixture({
params: {groupId: group.id},
});
const initialRouterConfig: RouterConfig = {
location: {
pathname: `/organizations/${organization.slug}/issues/${group.id}/similar/`,
},
route: '/organizations/:orgId/issues/:groupId/similar/',
};
let mockSimilarIssues: jest.Mock;

beforeEach(() => {
Expand Down Expand Up @@ -53,8 +60,7 @@ describe('SimilarIssuesDrawer', () => {
it('renders the content as expected', async () => {
render(<SimilarIssuesDrawer group={group} project={project} />, {
organization,
router,
deprecatedRouterMocks: true,
initialRouterConfig,
});

expect(
Expand Down
103 changes: 65 additions & 38 deletions static/app/views/issueDetails/streamline/issueDetailsEventNavigation.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
import {EventFixture} from 'sentry-fixture/event';
import {GroupFixture} from 'sentry-fixture/group';
import {LocationFixture} from 'sentry-fixture/locationFixture';
import {RouterFixture} from 'sentry-fixture/routerFixture';
import {OrganizationFixture} from 'sentry-fixture/organization';

import {initializeOrg} from 'sentry-test/initializeOrg';
import {render, screen, userEvent, waitFor} from 'sentry-test/reactTestingLibrary';
import {
render,
screen,
userEvent,
waitFor,
type RouterConfig,
} from 'sentry-test/reactTestingLibrary';

import {IssueDetailsEventNavigation} from './issueDetailsEventNavigation';

describe('IssueDetailsEventNavigation', () => {
const {organization, router} = initializeOrg();
const organization = OrganizationFixture();
const group = GroupFixture({id: 'group-id'});
const testEvent = EventFixture({
id: 'event-id',
Expand All @@ -28,6 +32,24 @@ describe('IssueDetailsEventNavigation', () => {
event: testEvent,
group,
};
const routerConfigBase: Pick<RouterConfig, 'routes'> = {
routes: [
'/organizations/:orgId/issues/:groupId/events/',
'/organizations/:orgId/issues/:groupId/events/:eventId/',
],
};
const latestRouterConfig: RouterConfig = {
...routerConfigBase,
location: {
pathname: `/organizations/${organization.slug}/issues/${group.id}/events/latest/`,
},
};
const recommendedRouterConfig: RouterConfig = {
...routerConfigBase,
location: {
pathname: `/organizations/${organization.slug}/issues/${group.id}/events/recommended/`,
},
};

beforeEach(() => {
jest.resetAllMocks();
Expand All @@ -39,58 +61,63 @@ describe('IssueDetailsEventNavigation', () => {

describe('recommended event tabs', () => {
it('can navigate to the oldest event', async () => {
render(<IssueDetailsEventNavigation {...defaultProps} isSmallNav />, {
router,
deprecatedRouterMocks: true,
});
const {router} = render(
<IssueDetailsEventNavigation {...defaultProps} isSmallNav />,
{
initialRouterConfig: latestRouterConfig,
}
);

await userEvent.click(await screen.findByRole('tab', {name: 'First'}));

expect(router.push).toHaveBeenCalledWith({
pathname: '/organizations/org-slug/issues/group-id/events/oldest/',
query: {referrer: 'oldest-event'},
});
await waitFor(() =>
expect(router.location.pathname).toBe(
'/organizations/org-slug/issues/group-id/events/oldest/'
)
);
expect(router.location.query).toEqual({referrer: 'oldest-event'});
});

it('can navigate to the latest event', async () => {
render(<IssueDetailsEventNavigation {...defaultProps} isSmallNav />, {
router,
deprecatedRouterMocks: true,
});
const {router} = render(
<IssueDetailsEventNavigation {...defaultProps} isSmallNav />,
{
initialRouterConfig: recommendedRouterConfig,
}
);

await userEvent.click(await screen.findByRole('tab', {name: 'Latest'}));

expect(router.push).toHaveBeenCalledWith({
pathname: '/organizations/org-slug/issues/group-id/events/latest/',
query: {referrer: 'latest-event'},
});
await waitFor(() =>
expect(router.location.pathname).toBe(
'/organizations/org-slug/issues/group-id/events/latest/'
)
);
expect(router.location.query).toEqual({referrer: 'latest-event'});
});

it('can navigate to the recommended event', async () => {
const recommendedEventRouter = RouterFixture({
params: {eventId: 'latest'},
location: LocationFixture({
pathname: `/organizations/org-slug/issues/group-id/events/latest/`,
}),
});

render(<IssueDetailsEventNavigation {...defaultProps} isSmallNav />, {
router: recommendedEventRouter,
deprecatedRouterMocks: true,
});
const {router} = render(
<IssueDetailsEventNavigation {...defaultProps} isSmallNav />,
{
initialRouterConfig: latestRouterConfig,
}
);

await userEvent.click(await screen.findByRole('tab', {name: 'Rec.'}));

expect(recommendedEventRouter.push).toHaveBeenCalledWith({
pathname: '/organizations/org-slug/issues/group-id/events/recommended/',
query: {referrer: 'recommended-event'},
});
await waitFor(() =>
expect(router.location.pathname).toBe(
'/organizations/org-slug/issues/group-id/events/recommended/'
)
);
expect(router.location.query).toEqual({referrer: 'recommended-event'});
});
});

it('can navigate next/previous events', async () => {
render(<IssueDetailsEventNavigation {...defaultProps} />, {
deprecatedRouterMocks: true,
initialRouterConfig: latestRouterConfig,
Copy link
Contributor

@cursor cursor bot Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing organization prop in render calls

The tests define an organization variable at the top level and use it to configure mock API responses in beforeEach, but don't pass it to the render() function. This causes the component to use a different organization instance created internally by initializeOrg(). While both have the same slug, this inconsistency could cause issues if organization objects are compared by reference or if other properties differ between instances.

Fix in Cursor Fix in Web

});

expect(await screen.findByRole('button', {name: 'Previous Event'})).toHaveAttribute(
Expand All @@ -117,7 +144,7 @@ describe('IssueDetailsEventNavigation', () => {
body: EventFixture(),
});
render(<IssueDetailsEventNavigation {...defaultProps} event={event} />, {
deprecatedRouterMocks: true,
initialRouterConfig: latestRouterConfig,
});

expect(mockNextEvent).not.toHaveBeenCalled();
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/issueList/issueViews/issueViewsList/issueViewsList.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ describe('IssueViewsList', () => {
],
});

render(<IssueViewsList />, {organization, deprecatedRouterMocks: false});
render(<IssueViewsList />, {organization});

// By default, sorts by popularity (desc) then visited (desc) then created (desc)
await waitFor(() => {
Expand Down
Loading