Skip to content

Conversation

@kcons
Copy link
Member

@kcons kcons commented Dec 4, 2025

delayed_workflow can fail to evaluate snuba queries and as a result potentially trigger incorrectly.
We already report this case, but only locally and without any reasonable way to assess the impact.

Extending the TriggerResult taint-tracking approach to delayed workflow condition evaluation allows us to start
tracking at least in terms of if-condition evaluations how many results are tainted vs not, giving us something much more user-relevant to alert on.

This should be refined further to be reported in terms of workflows and/or actions, but that's a follow-up.

Updates ACI-563.

@kcons kcons requested a review from ameliahsu December 4, 2025 00:43
@kcons kcons requested a review from a team as a code owner December 4, 2025 00:43
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 4, 2025
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...try/workflow_engine/processors/delayed_workflow.py 93.93% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #104368    +/-   ##
=========================================
  Coverage   80.57%    80.57%            
=========================================
  Files        9345      9345            
  Lines      399518    399673   +155     
  Branches    25600     25600            
=========================================
+ Hits       321894    322026   +132     
- Misses      77171     77194    +23     
  Partials      453       453            

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants