fix(aci): Extend taint tracking to delayed workflow condition evaluation #104368
+138
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delayed_workflow can fail to evaluate snuba queries and as a result potentially trigger incorrectly.
We already report this case, but only locally and without any reasonable way to assess the impact.
Extending the TriggerResult taint-tracking approach to delayed workflow condition evaluation allows us to start
tracking at least in terms of if-condition evaluations how many results are tainted vs not, giving us something much more user-relevant to alert on.
This should be refined further to be reported in terms of workflows and/or actions, but that's a follow-up.
Updates ACI-563.