ref(explorer): replace hamburger menu with top bar #104457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
aliu39
reviewed
Dec 5, 2025
aliu39
reviewed
Dec 5, 2025
aliu39
approved these changes
Dec 5, 2025
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| <Button | ||
| ref={sessionHistoryButtonRef} | ||
| icon={<IconTimer />} | ||
| onClick={() => onSessionHistoryClick(sessionHistoryButtonRef)} |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Comment on lines
217
to
219
| const panelRect = anchorElement | ||
| .closest('[data-seer-explorer-root]') | ||
| ?.getBoundingClientRect(); |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| isSessionHistoryOpen: boolean; | ||
| onFeedbackClick: () => void; | ||
| onNewChatClick: () => void; | ||
| onSessionHistoryClick: (buttonRef: React.RefObject<HTMLElement | null>) => void; |
Contributor
There was a problem hiding this comment.
Bug: Type signature mismatch for unused callback parameter
The onSessionHistoryClick prop is typed to accept a buttonRef parameter, and the button's onClick handler passes sessionHistoryButtonRef to it. However, the actual function passed from explorerPanel.tsx (openSessionHistory) takes no parameters and completely ignores the ref. The interface signature is misleading and the passed argument is never used.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the hamburger menu with a small top bar with buttons. This addresses feedback that the actions were hard to discover. Slash commands are still supported and the position of any menus changes to match whether you used the button or the slash command
Closes AIML-1953