Skip to content

Conversation

@Keshav-writes-code
Copy link

🧢 Changes

made changes to the build workflow to build on ubuntu-22.04 instead of latest ubuntu-24

☕️ Reasoning

this change will lower the glic requirements and will allow it run on older linux distros

🎫 Affected issues

Fixes: #11484

@vercel
Copy link

vercel bot commented Dec 8, 2025

@Keshav-writes-code is attempting to deploy a commit to the GitButler Team on Vercel.

A member of the Team first needs to authorize it.

@Keshav-writes-code Keshav-writes-code marked this pull request as ready for review December 8, 2025 04:57
Copilot AI review requested due to automatic review settings December 8, 2025 04:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Linux build runners in the publish workflow from Ubuntu 24.04 to Ubuntu 22.04 to improve compatibility with older Linux distributions by lowering the glibc requirements. The change affects both x64 and ARM64 Linux build targets.

Key Changes

  • Downgrade Linux x64 build runner from ubuntu-24.04 to ubuntu-22.04
  • Downgrade Linux ARM64 build runner from ubuntu-24.04-arm to ubuntu-22.04-arm
  • Changes applied consistently across two workflow jobs: build-tauri and publish-tauri

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@Byron
Copy link
Collaborator

Byron commented Dec 8, 2025

Thanks a lot for contributing!

I wish fixing this would be as easy as using an older ubuntu-22 image, but I do remember all of that being full of gotchas

Let me also check @slarse for a quick note with a thumbs up or down for whether to make a test Nightly build even. Your memory is definitely fresher than mine (even though I think I should know better 😅).

@Byron Byron added the feedback requested Feedback was requested to help resolve the issue label Dec 8, 2025
@Byron
Copy link
Collaborator

Byron commented Dec 8, 2025

@Keshav-writes-code I think it would be good if you could catch up on #7671 (comment) .

@slarse
Copy link
Contributor

slarse commented Dec 8, 2025

Thanks a lot for contributing!

I wish fixing this would be as easy as using an older ubuntu-22 image, but I do remember all of that being full of gotchas

Let me also check @slarse for a quick note with a thumbs up or down for whether to make a test Nightly build even. Your memory is definitely fresher than mine (even though I think I should know better 😅).

With the current state of affairs, we should build for both Ubuntu 22.04 and Ubuntu 24.04, as I've prepped for in #11412. As can be seen in the testing matrix I set up in #11412, building on Ubuntu 22.04 makes forward compatibility worse for the AppImage. I think the deb and rpm packages should fare somewhat better but I haven't tested them across any interesting range of hardware and OS. I've been meaning to get to that ASAP but life got in the way.

As WebKit have technically dropped support for Ubuntu 22.04, it's unclear for how long Ubuntu 22.04 will continue to be supported (it still seemingly is). So I don't think it's a good idea to drop the Ubuntu 24.04 build for that reason alone.

For #11412 to be merged we need the website updates mentioned here, and I can't do those.

@Keshav-writes-code There is a Discord thread over here for discussing Linux distro compatibility, if you want to join in.

@Byron
Copy link
Collaborator

Byron commented Dec 9, 2025

My greatest of apologies for mismanaging this PR so badly. My memory was just too bad on this one as I didn't even think of looking for @slarse 's PRs to find the one that already implements this, and more.

Thus, I think it's best to close this PR in favor of #11412 .
Thanks for your understanding, and please, keep contributing your know-how and good-will to make the Linux distribution better, we need it :).
🙏

@Byron Byron closed this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feedback requested Feedback was requested to help resolve the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

`GLIBC_2.38' not found

3 participants