-
Notifications
You must be signed in to change notification settings - Fork 731
Compatibility Linux: Add support for older Linux Distros #11485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Keshav-writes-code is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Linux build runners in the publish workflow from Ubuntu 24.04 to Ubuntu 22.04 to improve compatibility with older Linux distributions by lowering the glibc requirements. The change affects both x64 and ARM64 Linux build targets.
Key Changes
- Downgrade Linux x64 build runner from
ubuntu-24.04toubuntu-22.04 - Downgrade Linux ARM64 build runner from
ubuntu-24.04-armtoubuntu-22.04-arm - Changes applied consistently across two workflow jobs:
build-tauriandpublish-tauri
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
|
Thanks a lot for contributing! I wish fixing this would be as easy as using an older Let me also check @slarse for a quick note with a thumbs up or down for whether to make a test Nightly build even. Your memory is definitely fresher than mine (even though I think I should know better 😅). |
Co-authored-by: Keshav-writes-code <[email protected]>
Co-authored-by: Keshav-writes-code <[email protected]>
0c0daaa to
2543e93
Compare
|
@Keshav-writes-code I think it would be good if you could catch up on #7671 (comment) . |
With the current state of affairs, we should build for both Ubuntu 22.04 and Ubuntu 24.04, as I've prepped for in #11412. As can be seen in the testing matrix I set up in #11412, building on Ubuntu 22.04 makes forward compatibility worse for the AppImage. I think the deb and rpm packages should fare somewhat better but I haven't tested them across any interesting range of hardware and OS. I've been meaning to get to that ASAP but life got in the way. As WebKit have technically dropped support for Ubuntu 22.04, it's unclear for how long Ubuntu 22.04 will continue to be supported (it still seemingly is). So I don't think it's a good idea to drop the Ubuntu 24.04 build for that reason alone. For #11412 to be merged we need the website updates mentioned here, and I can't do those. @Keshav-writes-code There is a Discord thread over here for discussing Linux distro compatibility, if you want to join in. |
|
My greatest of apologies for mismanaging this PR so badly. My memory was just too bad on this one as I didn't even think of looking for @slarse 's PRs to find the one that already implements this, and more. Thus, I think it's best to close this PR in favor of #11412 . |
🧢 Changes
made changes to the build workflow to build on ubuntu-22.04 instead of latest ubuntu-24
☕️ Reasoning
this change will lower the glic requirements and will allow it run on older linux distros
🎫 Affected issues
Fixes: #11484