skip serializableCheck for RTK Query state/cache #11514
Conversation
This serializableCheck is not needed since this data is loaded via JSON request and therefore always serializable. This change makes the UI a lot snappier and removes these warnings: `SerializableStateInvariantMiddleware took 1590ms, which is more than the warning threshold of 32ms. `
|
@uwemaurer is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
This PR optimizes Redux middleware configuration by skipping serializable state checks for RTK Query cache slices (backend, github, gitlab). Since RTK Query data originates from JSON API responses, it is inherently serializable, making the check redundant and expensive. This change addresses performance warnings where SerializableStateInvariantMiddleware was taking over 1590ms (far exceeding the 32ms threshold), resulting in a noticeably snappier UI.
- Adds
ignoredPathsconfiguration to skip serializable checks for RTK Query slices - Improves UI responsiveness by eliminating expensive middleware checks
- Adds explanatory comment documenting why these paths are safe to ignore
Oh interesting! Nice catch. There is some lint error but other than that looks good to go! |
2 participants
This serializableCheck is not needed since this data is loaded via JSON request and therefore always serializable.
This change makes the UI a lot snappier and
removes these warnings:
SerializableStateInvariantMiddleware took 1590ms, which is more than the warning threshold of 32ms.