Skip to content

Conversation

@bentsherman
Copy link

Description

This PR updates configuration for the Nextflow language:

  • Update the grammar repository
  • Update the color to match Nextflow branding
  • Update code samples to match current syntax

cc @ewels

Checklist:

@bentsherman bentsherman requested a review from a team as a code owner November 13, 2025 19:44
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not change samples. If the language has evolved, it is better to add new samples.

We also need the updated cached license file which would have been generated when you ran script/add-grammar to replace the grammar.

The link supporting the discussion in the template for the colour change needs to be an actual community discussion where the wider community has agreed on the change, not a link to the branding.

@bentsherman
Copy link
Author

The link supporting the discussion in the template for the colour change needs to be an actual community discussion where the wider community has agreed on the change, not a link to the branding.

The color change was made by Seqera, the company that owns Nextflow, so there is no community discussion for this. You can see this new color reflected in the GitHub repository and website

@bentsherman
Copy link
Author

I reverted the samples and updated the license. I had trouble running the add-grammar tool, possibly because it didn't seem to recognize the old atom-language-nextflow submodule. Maybe because the repo is archived? In any case, I have tried to update everything manually to the best of my ability.

@bentsherman bentsherman requested a review from lildude November 13, 2025 22:20
@lildude
Copy link
Member

lildude commented Nov 14, 2025

The color change was made by Seqera, the company that owns Nextflow, so there is no community discussion for this. You can see this new color reflected in the GitHub repository and website

That may be the case but this is about changing the colour on GitHub. People get very sensitive about simple things like this, even when the language creators make these decisions, and we need somewhere to direct them when they come asking.

@bentsherman
Copy link
Author

In that case the brand website or Nextflow website should be enough... any community discussion at this point would be kind of moot given that we've already changed the color everywhere else

@ewels do you have any ideas here? I don't know what else we can do

@lildude lildude changed the title Update Nextflow Replace Nextflow grammar and change colour Nov 14, 2025
@ewels
Copy link

ewels commented Nov 15, 2025

Crikey, this was a while ago. I think the official announcement was in 2023, see this blog post.

The main place for community discussion is now https://community.seqera.io/tag/nextflow , but we launched that around the same time that the colour and logo changed, so I don't think that there are any posts on this topic or anything. The repo with the trademark and official logos (with the colour) is here: https://github.com/nextflow-io/trademark

There's plenty of evidence of community adoption of the new logo and colour. The simplest way to see this is to search for "Nextflow" on Google Images and filter for the past year. Basically everything uses the new colour.

Is this enough @lildude? If you can think of anything else specific that you'd like to see I can try to dig something up.

@lildude
Copy link
Member

lildude commented Nov 20, 2025

Thanks @ewels. I'll take that as sufficient evidence. If anyone complains, I'll send them your/Seqera's way 😉

I had trouble running the add-grammar tool, possibly because it didn't seem to recognize the old atom-language-nextflow submodule. Maybe because the repo is archived? In any case, I have tried to update everything manually to the best of my ability.

Yeah, so that doesn't look like it's worked given the test failures. The fact the original repo is archived doesn't matter as we don't reach out to it when replacing the grammar.

@ewels
Copy link

ewels commented Nov 21, 2025

If anyone complains, I'll send them your/Seqera's way 😉

Absolutely, happy to take the blame! 😅 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants