-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Replace Nextflow grammar and change colour #7668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
lildude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not change samples. If the language has evolved, it is better to add new samples.
We also need the updated cached license file which would have been generated when you ran script/add-grammar to replace the grammar.
The link supporting the discussion in the template for the colour change needs to be an actual community discussion where the wider community has agreed on the change, not a link to the branding.
The color change was made by Seqera, the company that owns Nextflow, so there is no community discussion for this. You can see this new color reflected in the GitHub repository and website |
9a2a2cb to
8b4b90e
Compare
|
I reverted the samples and updated the license. I had trouble running the |
That may be the case but this is about changing the colour on GitHub. People get very sensitive about simple things like this, even when the language creators make these decisions, and we need somewhere to direct them when they come asking. |
|
In that case the brand website or Nextflow website should be enough... any community discussion at this point would be kind of moot given that we've already changed the color everywhere else @ewels do you have any ideas here? I don't know what else we can do |
|
Crikey, this was a while ago. I think the official announcement was in 2023, see this blog post. The main place for community discussion is now https://community.seqera.io/tag/nextflow , but we launched that around the same time that the colour and logo changed, so I don't think that there are any posts on this topic or anything. The repo with the trademark and official logos (with the colour) is here: https://github.com/nextflow-io/trademark There's plenty of evidence of community adoption of the new logo and colour. The simplest way to see this is to search for "Nextflow" on Google Images and filter for the past year. Basically everything uses the new colour. Is this enough @lildude? If you can think of anything else specific that you'd like to see I can try to dig something up. |
|
Thanks @ewels. I'll take that as sufficient evidence. If anyone complains, I'll send them your/Seqera's way 😉
Yeah, so that doesn't look like it's worked given the test failures. The fact the original repo is archived doesn't matter as we don't reach out to it when replacing the grammar. |
Absolutely, happy to take the blame! 😅 Thanks! |
Description
This PR updates configuration for the Nextflow language:
cc @ewels
Checklist:
I am changing the source of a syntax highlighting grammar
I am changing the color associated with a language