[IainSAP]

Pull Request Checklist

• I have read the contribution guidelines
• I have reviewed the guidance for paid services (if applicable)
• I have added files to the correct directories
• I have followed naming conventions
• I have tested my changes with GitHub Copilot
• I have run npm start to verify README updates

Description

Updates the sap-ux-fiori-tools plugin version from 1.16.0 to 1.16.6 and updates the source SHA to the corresponding commit in SAP/open-ux-tools.

Type of Contribution

• Update to existing item

Additional Notes

N/A

[github-actions]

🚦 Submission status: 🛠️ Requires submitter fixes

Risk tier: merge-risk:high — Privileged execution, automation, or review-policy change
Required to merge: passing submission-gate checks plus 1 approval from reviewers with write access, including a maintainer with admin or maintain permission.

Why this tier

• plugins/external.json is a high-risk path (automation, scripts, MCP config, hooks, or review policy)

Automated checks

Check	Status	Details
Line endings	✅ Passed	Passed · logs
Spelling	✅ Passed	Passed · logs
Generated README consistency	✅ Passed	Passed · logs
Plugin and extension validation	✅ Passed	Passed · logs
Plugin structure	✅ Passed	Passed · logs
Risk scan	✅ Passed	Passed · logs
Contributor reputation	✅ Passed	Passed · logs
Duplicate resource scan	✅ Passed	Passed · logs
PR quality signal	⏭️ Skipped	Skipped by its workflow · logs
Canvas/plugin smoke test	✅ Passed	Passed · logs

Action needed

• Address the changes requested by aaronpowell, then push an update.

Review

• Approvals: 0/1
• Assigned reviewer: not assigned yet — comment /request-review to ask for one
• Review target date: not set
• Still needed: 1 more approval(s); an approval from a maintainer with admin or maintain permission; resolution of changes requested by aaronpowell
• The core-maintainers pool is not staffed yet; an approver with admin or maintain permission is required instead.

Commands

Command	Who	What it does
/rerun-checks	PR author, maintainers	Re-runs failed or incomplete checks and re-evaluates this gate
/request-review	PR author, maintainers	Asks the review rotation to assign a reviewer (adds needs-reviewer)

_{Updated for 671a141 · gate run · This comment is maintained automatically — see submission gate docs.}

[github-actions]

🛑 External plugin PR checks failed (submitter fixes required)

• Changed entries detected: 1
• Workflow state label: requires-submitter-fixes
• Full logs: Download quality gate artifact
• Status legend: ✅ pass · ⚠️ warning · 🛑 fail

Per-plugin quality summary

Plugin	spec compliance	vally lint	install smoke test	version match	ref/sha consistency	canvas structure	overall	source tree
sap-ux-fiori-tools	🛑 fail	✅ pass	✅ pass	✅ pass	⚪ not_run	⚪ not_run	🛑 fail	4fb662cb3c3e5600c8f4e80dc340c909fbcdedf0

Gate output details

sap-ux-fiori-tools - spec compliance (🛑 fail)

Agent Plugins v1.0.0 manifest errors:
- manifest location is ".github/plugin/plugin.json"; expected "plugin.json" at plugin root

sap-ux-fiori-tools - vally lint (✅ pass)

✅ sap-fiori-add-visual-filter (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.
✅ sap-fiori-analytical-chart (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.
✅ sap-fiori-app-development (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.
✅ sap-fiori-create-cli (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.
✅ sap-fiori-eslint-plugin (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.
✅ sap-fiori-opa5-test-development (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.
✅ sap-fiori-tree-table (2/2 checks passed)

...output truncated...

sap-ux-fiori-tools - install smoke test (✅ pass)

Install smoke test succeeded. Verified /tmp/external-plugin-quality-4sDWtS/copilot-home/.copilot/installed-plugins/external-plugin-intake/sap-ux-fiori-tools/.github/plugin/plugin.json.

sap-ux-fiori-tools - version match (pass)

- 4fb662cb3c3e5600c8f4e80dc340c909fbcdedf0: matched version "1.16.6" at "plugins-coding-agents/fiori/.github/plugin/plugin.json".

sap-ux-fiori-tools - ref/sha consistency (not_run)

Ref/SHA consistency gate skipped because one of source.ref or source.sha was not provided.

sap-ux-fiori-tools - canvas structure (not_run)

Canvas structure gate skipped because plugin is not tagged with "canvas".

- sap-ux-fiori-tools: spec=fail, vally-lint=pass, install-smoke=pass, version-match=pass, ref-sha-consistency=not_run, canvas-structure=not_run, overall=fail

[github-actions]

🔒 PR Risk Scan Results

Scanned 2 changed file(s).

Severity	Count
🔴 High	0
🟠 Medium	0
ℹ️ Info	0

✅ No matching risk patterns were detected in changed files.

This is an automated soft-gate report. Findings indicate review targets and do not block merge by themselves.

[aaronpowell]

The external-plugin quality gate is failing for the updated source: at SAP/open-ux-tools/plugins-coding-agents/fiori, the manifest is still .github/plugin/plugin.json, but Agent Plugins v1.0.0 requires plugin.json at the plugin root. Please pin a source revision that has the manifest in the required location, then rerun the quality gate.

[IainSAP]

@aaronpowell — fixed. We bumped the source SHA to 653ac13f5e (SAP/open-ux-tools#5358) which restructures the plugin and moves plugin.json to the plugin root. Quality gates (run-quality-gates, enforce-quality-gates) are now passing on the updated commit. Could you re-review when you get a chance?

[IainSAP]

/rerun-checks

[github-actions]

🔁 /rerun-checks for 671a141

Re-running: Submission Gate.

The status comment updates when the checks finish.

[IainSAP]

/request-review

[github-actions]

🙋 Added needs-reviewer. Reviewer routing is assigning a reviewer now.