fix(security): force esbuild >=0.28.1 (GHSA-g7r4-m6w7-qqqr / alert #35)#114
Merged
Conversation
Adds an npm "overrides" entry pinning esbuild to ^0.28.1, which dedupes the transitive copies pulled by astro 6.4.8 and vite 7.3.5 (previously 0.27.7, in the vulnerable >=0.27.3 <0.28.1 range) up to the patched 0.28.1. Resolves Dependabot alert #35 (low: dev-server arbitrary file read on Windows) without the astro 7 / vite 8 migration proposed in #112. Verified with Node 22: astro check, astro build, and Playwright tests all pass; npm audit no longer flags esbuild. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Dependabot alert #35 (GHSA-g7r4-m6w7-qqqr) by forcing the transitive esbuild dependency to resolve to a patched version (>= 0.28.1) without requiring a major astro upgrade.
Changes:
- Add an npm
overridesentry to pinesbuildto^0.28.1. - Update
package-lock.jsonsoesbuildand all@esbuild/*platform packages resolve to0.28.1.
Show a summary per file
| File | Description |
|---|---|
| package.json | Adds an npm override to force esbuild to a patched version across the dependency graph. |
| package-lock.json | Updates the lockfile to reflect esbuild@0.28.1 (and platform binaries) as the resolved versions. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Dependabot alert #35 —
esbuildGHSA-g7r4-m6w7-qqqr(low: dev-server arbitrary file read on Windows, vulnerable>=0.27.3 <0.28.1, patched 0.28.1).Approach
esbuild is a transitive dependency (via
astro@6.4.8andvite@7.3.5), resolving to0.27.7onmain. Rather than take #112'sastro6→7 jump (which drags in the broken Vite 8 / rolldown + Tailwind migration), this adds a one-line npmoverridesentry pinning esbuild to^0.28.1. Both astro and vite dedupe to the patched build:Verification (local, Node 22 = CI)
npm run checknpm run buildnpm run test(Playwright)npm audit(esbuild)Follow-up
This fully addresses the security alert, so #112 (astro 7) can be closed — it remains a separate, non-security migration (Vite 8/rolldown + Tailwind rework) tracked on its own.