Webgpu: Add support for "sheen", "specular color", "specular intensity" - #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for sheen, specular color, and specular intensity features, based on the WebGL implementation which just adjusts colors in the evaluate function rather than providing a separate sample-able BRDF lobe for sheen (I've added a note that it's something that could be added in the future).
The "specular color" and "specular intensity" application has also been adjusted compared to the WebGLPathTracer version to better align with the gltf spec.
Some test models:
There are some visible artifacts in the toy car demo but these were present previously and I expect will be addressed with #792.