Add support for anonymous readonly classes#1168
Merged
czosel merged 2 commits intoglayzzle:mainfrom Feb 13, 2026
Merged
Conversation
czosel
reviewed
Feb 11, 2026
Collaborator
czosel
left a comment
czosel
left a comment
There was a problem hiding this comment.
Thanks for contributing @olivereisenhut! This looks great, just a tiny tweak and we can get this merged.
src/parser/expr.js
Outdated
Comment on lines
766
to
770
| const isReadonly = this.token === this.tok.T_READ_ONLY; | ||
| if ( | ||
| this.token === this.tok.T_CLASS || | ||
| (isReadonly && this.next().token === this.tok.T_CLASS) | ||
| ) { |
Collaborator
There was a problem hiding this comment.
Let's add a version check, and a slight refactor of the control flow along the lines of this:
Suggested change
| const isReadonly = this.token === this.tok.T_READ_ONLY; | |
| if ( | |
| this.token === this.tok.T_CLASS || | |
| (isReadonly && this.next().token === this.tok.T_CLASS) | |
| ) { | |
| const isReadonly = this.token === this.tok.T_READ_ONLY; | |
| if (isReadonly) { | |
| if (this.version < 830) { | |
| // throw exception | |
| } | |
| this.next(); | |
| } | |
| if (this.token === this.tok.T_CLASS) { |
Contributor
Author
|
Thanks for reviewing the PR, @czosel. I have added the version check and a test for it. |
czosel
approved these changes
Feb 13, 2026
Collaborator
czosel
left a comment
czosel
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks again for contributing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for anonymous classes that are readonly.
e.g
new readonly {}.