This repository was archived by the owner on Jan 15, 2022. It is now read-only.
Adding the ability to use complex forms in filters #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the user to put more complex formatting into the table (e.g. React components) and still filter the table based on those rows.
Currently, while the custom sort functions are fed the raw contents of each cell (& so get react components directly if they're being used), the filter functions get a stringified version, meaning everything gets filtered against
[object Object], which is not especially useful. This tries to preserve all current use cases, but in the event thattoString()returns[object Object], it sends the object (presumably a React component, though it could be something complex within the data array.)