Skip to content

Day 0#10

Open
PaoRioColorado wants to merge 7 commits intoglobant-ui:masterfrom
PaoRioColorado:master
Open

Day 0#10
PaoRioColorado wants to merge 7 commits intoglobant-ui:masterfrom
PaoRioColorado:master

Conversation

@PaoRioColorado
Copy link
Copy Markdown

Exercises Day 0

Comment thread src/week1/day0/image.html
<body>

<iframe width="100%" height="300" scrolling="no" frameborder="no" allow="autoplay" src="https://w.soundcloud.com/player/?url=https%3A//api.soundcloud.com/users/505028589&color=%23ff0099&auto_play=false&hide_related=false&show_comments=true&show_user=true&show_reposts=false&show_teaser=true&visual=true"> Your browser does not support the audio element.</iframe>
<center>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this tag is deprecated

Comment thread src/week1/day0/form.html

<br>

<label>Favorite sport </label>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing label link with select

Comment thread src/week1/day0/form.html

</header>

<form action="">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing accessibility for all form controls

Comment thread src/week1/day0/form.html
<fieldset>
<legend>Sports practice? </legend>
<label>
<input type="radio" name="yes" value="yes"> Yes</label>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related radio buttons should belong to the same group (check the app and see how the options remains selected)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants