Add missing 'filter_roles' to Search index_list#1376
Merged
sirosen merged 1 commit intoglobus:mainfrom Mar 20, 2026
Merged
Conversation
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
sirosen
force-pushed
the
search-filter-roles
branch
from
8e57926 to
1392131
Compare
This parameter was missing from SearchClient, although it was added last year. In terms of the client changes, this follows the patterns we have already established for a query parameter which is a comma-delimited list. The value type or an iterable thereof is acceptable, and our commajoin remarshalling helper ensures proper handling. The parameter is merged in with passthrough query params. The valid values (since it is a string) are declared as a Literal, which gives good typing-time assistance to developers/users but still allows any value at runtime. A new test for this usage is introduced, using a param class to define test parameters in a compact manner.
sirosen
force-pushed
the
search-filter-roles
branch
from
1392131 to
352468a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This parameter was missing from SearchClient, although it was added last
year.
In terms of the client changes, this follows the patterns we have already
established for a query parameter which is a comma-delimited list. The
value type or an iterable thereof is acceptable, and our commajoin
remarshalling helper ensures proper handling. The parameter is merged in
with passthrough query params.
The valid values (since it is a string) are declared as a Literal, which
gives good typing-time assistance to developers/users but still allows
any value at runtime.
A new test for this usage is introduced, using a param class to define
test parameters in a compact manner.