Skip to content

Conversation

@gfanton
Copy link
Member

@gfanton gfanton commented Oct 20, 2025

TODO

Capture d’écran 2025-10-27 à 10 56 29

@gfanton gfanton requested a review from alexiscolin October 20, 2025 11:43
@github-actions github-actions bot added 📦 ⛰️ gno.land Issues or PRs gno.land package related 🌍 gnoweb Issues & PRs related to gnoweb and render labels Oct 20, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Oct 20, 2025

🛠 PR Checks Summary

🔴 Changes related to gnoweb must be reviewed by its codeowners

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🔴 Changes related to gnoweb must be reviewed by its codeowners

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: gfanton/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Changes related to gnoweb must be reviewed by its codeowners

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 A changed file matches this pattern: ^gno.land/pkg/gnoweb/ (filename: gno.land/pkg/gnoweb/app.go)

Then

🔴 Requirement not satisfied
└── 🔴 Or
    ├── 🔴 Or
    │   ├── 🔴 And
    │   │   ├── 🔴 Pull request author is user: alexiscolin
    │   │   └── 🔴 This user reviewed pull request: gfanton (with state "APPROVED")
    │   └── 🔴 And
    │       ├── 🟢 Pull request author is user: gfanton
    │       └── 🔴 This user reviewed pull request: alexiscolin (with state "APPROVED")
    └── 🔴 And
        ├── 🟢 Not (🔴 Pull request author is user: alexiscolin)
        ├── 🔴 Not (🟢 Pull request author is user: gfanton)
        └── 🔴 Or
            ├── 🔴 This user reviewed pull request: alexiscolin (with state "APPROVED")
            └── 🔴 This user reviewed pull request: gfanton (with state "APPROVED")

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@michelleellen
Copy link
Contributor

@alexiscolin @aeddi any way we can get this merged? It would be great to have for Boards given currently it is challenging to fill in any long form content for general users.

@alexiscolin
Copy link
Member

@michelleellen we are currently working on it together. We will have some news very soon.

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Nov 13, 2025
}

.btn-copy {
background-color: var(--transparent);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
background-color: var(--transparent);
background-color: var(--g-color-transparent);

@alexiscolin Wouldn't it be ⁠--g-color-transparent instead like the rest of the file?

@aeddi
Copy link
Contributor

aeddi commented Nov 17, 2025

There was a tricky issue to solve around generating command blocks from the markdown package (form exec) and the components package (actions page). For the sake of consistency and to fix the gosec-related problems, I made the command block HTML be generated via a template instead of a function using printf.

In this scenario, because the markdown package needed to import the command block template and the associated types, I had to fix a circular import by moving the TocItem definition into a subpackage of markdown. It would probably be cleaner to move all of these types into a package shared by markdown and components. While we wait for @gfanton to get back, I propose merging this as-is to unblock @jeronimoalbi, and letting @gfanton post-review or make changes (if needed) when he return.

The two commits on this are: 9ee5494 and bfba98f.

@aeddi aeddi marked this pull request as ready for review November 17, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌍 gnoweb Issues & PRs related to gnoweb and render 📦 ⛰️ gno.land Issues or PRs gno.land package related 🧾 package/realm Tag used for new Realms or Packages.

Projects

Status: No status
Status: Triage

Development

Successfully merging this pull request may close these issues.

5 participants