fix: preserve original method case in CORS preflight responses#40
Open
lihan3238 wants to merge 1 commit into
Open
fix: preserve original method case in CORS preflight responses#40lihan3238 wants to merge 1 commit into
lihan3238 wants to merge 1 commit into
Conversation
Stop uppercasing AllowedMethods at config time and use case-insensitive comparison (strings.EqualFold) for method matching. This preserves the user-configured method case in Access-Control-Allow-Methods responses. Fixes go-chi#27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27
Summary
Stop uppercasing AllowedMethods at config time and use case-insensitive comparison (strings.EqualFold) for method matching. This preserves the user-configured method case in Access-Control-Allow-Methods responses.
Before this fix, configuring AllowedMethods with lowercase methods (e.g., patch) would result in the response header being uppercased (PATCH), losing the original case.
Changes
Test
Added TestHandlePreflightLowercaseAllowedMethod from #27 — verifies that a lowercase method is preserved in the response.