Prevent stack overflow from cyclic key references - #410
Open
rupayon123 wants to merge 1 commit into
Open
rupayon123 wants to merge 1 commit into
rupayon123 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading mutually referencing keys can overflow the Go process stack (#409).
Key.String()recursively calls another key'sString()without tracking which keys are already on the current resolution path; the existing per-value loop limit does not constrain that recursion.Track the keys visited by each resolution call and leave a reference unresolved when it points back to a key already being resolved. This matches the existing direct self-reference behavior while allowing ordinary acyclic references and
ValueMapperprocessing to continue. There is no shared state between calls.An isolated reproducer on the previous code terminated with
fatal error: stack overflow(stack capped at 1 MiB for safety). After the change it returns%(a)s. New tests cover two-key and three-key cycles; existing self-reference, default-section and mapper tests pass.go test -race ./...,go vet ./...,go test -cover ./...(93.7% reported statement coverage), gofmt andgit diff --checkpass on macOS/Go 1.27.1. Remote CI is tracked separately.Prepared with OpenAI Codex assistance on behalf of rupayon123. No independent human review is claimed.