Skip to content

Read go.mod path from output of go env GOMOD if go.mod not exists - #28

Open
bbiao wants to merge 1 commit into
gobuffalo:mainfrom
bbiao:next
Open

Read go.mod path from output of go env GOMOD if go.mod not exists#28
bbiao wants to merge 1 commit into
gobuffalo:mainfrom
bbiao:next

Conversation

@bbiao

@bbiao bbiao commented Aug 21, 2019

Copy link
Copy Markdown

When working directory is not a module's root, go.mod can't be read. But use go env GOMOD will recursively find it in parent directory.

@bbiao
bbiao force-pushed the next branch 8 times, most recently from b450c3d to c4cea44 Compare August 21, 2019 16:36
When working directory is not a module's root, go.mod can't be read. But use `go env GOMOD` will recursively find it in parent directory.
@sio4

sio4 commented Jul 23, 2022

Copy link
Copy Markdown
Member

Thank you @bbiao for filing a PR! (sorry for the late response)

Currently, I am considering the deprecation of the function (#42) but will still have this PR in consideration.

Thanks!

@sio4 sio4 self-assigned this Jul 23, 2022
@sio4 sio4 added the s: triage Some tests need to be run to confirm the issue label Jul 23, 2022
@sio4 sio4 added this to the v2 milestone Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

s: triage Some tests need to be run to confirm the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants