Fix lowercase acronym pluralization - #86
Open
deepakganesh78 wants to merge 1 commit into
Open
Conversation
Only apply case-sensitive suffix rules when the normalized last part is an exact suffix of the original input. This lets lowercase acronyms ending in s fall through to the existing already-plural handling without duplicating their uppercase form. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixes #71
Known acronyms are normalized to uppercase in
Ident.Parts. The suffix-rule loops therefore matched the uppercase abbreviation rule for inputs such asdns, butReplaceSuffixcould not remove the differently-cased suffix from the original string, producingdnsDNSes.Suffix rules now run only when the normalized last part is an exact suffix of the original input. Lowercase
dns,ids, andhttpsfall through to the existing already-plural handling, while uppercaseDNS,IDS, andHTTPSretain their current-esbehavior. The same guard is applied to singularization to prevent the analogous duplicated acronym result.Tests
go test ./... -run '^(Test_Pluralize|Test_PluralizeWithSize|Test_Singularize|Test_SingularizeWithSize)$' -count=1go test -cover ./... -count=1go vet ./...golangci-lint run --new-from-rev=main(0 issues)govet,ineffassign,misspell,nakedret,unconvert,staticcheck) (0 issues)go test -race ./...was attempted, but the local Windows Go toolchain has CGO disabled and no C compiler; the upstream Standard Test workflow will exercise its configured race run.