fix: add bounds check in Row.matchAll to prevent slice panic#68
Open
Yanhu007 wants to merge 1 commit into
Open
fix: add bounds check in Row.matchAll to prevent slice panic#68Yanhu007 wants to merge 1 commit into
Yanhu007 wants to merge 1 commit into
Conversation
Row.matchAll could panic with "slice bounds out of range" when
the computed end index exceeded the string length. This happened
with certain malformed glob patterns like "/{a{*.json{" matched
against valid paths.
Add a bounds check before slicing to prevent the panic.
Fixes gobwas#59
320a73e to
a177d70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59
Problem
Row.matchAllcomputesidx+next+1as the slice end without checking if it exceedslen(s). With certain compiled patterns, this causes a panic:Fix
Add a bounds check before slicing: