Skip to content

Remove memoryqos required field #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfanjie merged 1 commit into from
Nov 15, 2024
Merged

Remove memoryqos required field #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions artifacts/deploy/ensurance.crane.io_podqoss.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,9 +241,6 @@ spec:
asyncRatio:
format: int64
type: integer
required:
- asyncDistanceFactor
- asyncRatio
type: object
memPageCacheLimit:
properties:
Expand All @@ -253,9 +250,6 @@ spec:
pageCacheReclaimRatio:
format: int64
type: integer
required:
- pageCacheMaxRatio
- pageCacheReclaimRatio
type: object
memPriority:
description: MemoryPriority define the memory priority for
Expand All @@ -271,8 +265,6 @@ spec:
properties:
watermarkRatio:
type: integer
required:
- watermarkRatio
type: object
memoryCompression:
properties:
Expand Down
10 changes: 5 additions & 5 deletions ensurance/v1alpha1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,18 +197,18 @@ type MemoryQOS struct {
}

type MemPageCacheLimit struct {
PageCacheMaxRatio *int64 `json:"pageCacheMaxRatio"`
PageCacheReclaimRatio *int64 `json:"pageCacheReclaimRatio"`
PageCacheMaxRatio *int64 `json:"pageCacheMaxRatio,omitempty"`
PageCacheReclaimRatio *int64 `json:"pageCacheReclaimRatio,omitempty"`
}

type MemAsyncReclaim struct {
AsyncRatio *int64 `json:"asyncRatio"`
AsyncDistanceFactor *int64 `json:"asyncDistanceFactor"`
AsyncRatio *int64 `json:"asyncRatio,omitempty"`
AsyncDistanceFactor *int64 `json:"asyncDistanceFactor,omitempty"`
}

// MemWatermark to set memory watermark priority
type MemWatermark struct {
WatermarkRatio *int `json:"watermarkRatio"`
WatermarkRatio *int `json:"watermarkRatio,omitempty"`
}

type NetIOQOS struct {
Expand Down
Loading