generated from readthedocs/tutorial-template
-
-
Notifications
You must be signed in to change notification settings - Fork 11
[WIP][Documentation] Add information on what not to document #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
AThousandShips
wants to merge
1
commit into
godotengine:main
Choose a base branch
from
AThousandShips:to_document_or_not_to_document
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -59,6 +59,20 @@ documentation's scope. For example, you could link to an introduction to | |||||||||||||
| programming in the getting started guide, or a website that teaches math theory | ||||||||||||||
| in the math section. | ||||||||||||||
|
|
||||||||||||||
| Finally it's also important to know what *not* to document; there are a some cases | ||||||||||||||
| where things should be left out of the documentation to avoid causing problems. | ||||||||||||||
| Some behaviors or details of how some part of the engine works might be unintentional, | ||||||||||||||
| unknown to the maintainers, or be an implementation detail rather than part of the | ||||||||||||||
| real goal of that feature. This means that these details might change when bugs are | ||||||||||||||
| fixed or new features are added, as they are not part of the intended behavior or | ||||||||||||||
| goal of the feature; so documenting them would risk making people rely on things | ||||||||||||||
| that might change in the future if maintainers are not aware that this has been | ||||||||||||||
| documented. | ||||||||||||||
|
|
||||||||||||||
| Anything that is documented is also generally considered part of the official API, | ||||||||||||||
| meaning that changing it could be considered breaking compatibility, this risks | ||||||||||||||
| limiting what changes can be done even when necessary. | ||||||||||||||
|
Comment on lines
+72
to
+74
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
|
|
||||||||||||||
| Limiting cognitive load | ||||||||||||||
| ~~~~~~~~~~~~~~~~~~~~~~~ | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use shorter sentences (especially since the paragraph is long):