fix: remove debug log statement from member view#1000
Open
AdeshDeshmukh wants to merge 1 commit into
Open
Conversation
AdeshDeshmukh
force-pushed
the
fix/remove-debug-log-member-view
branch
from
e1ab1aa to
f1ad4c9
Compare
Removes leftover debug statement that printed raw column metadata to stderr during member view rendering in non-wide format. Also removes the now-unused 'log' import as required by Go. Signed-off-by: Adesh Deshmukh <adeshkd123@gmail.com> Fixes goharbor#5
AdeshDeshmukh
force-pushed
the
fix/remove-debug-log-member-view
branch
from
f1ad4c9 to
2c0ce9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes a leftover debug
log.Println()statement that was polluting terminal output when viewing project members.Problem
When users ran member view commands in non-wide format, they saw raw internal struct data printed to their terminal:
This was noise from a debugging statement accidentally left in production code at line 66 of
pkg/views/member/view/view.go.What This PR Does
✅ Removes the
log.Println(columns)debug statement✅ Removes the now-unused
"log"import (required by Go compiler)What Stays the Same
The actual behavior is completely unchanged. The
columnsvariable is still used exactly as before to build the table model on line 73. This PR only removes the unintended debug noise that was leaking into user-facing output.Changes
pkg/views/member/view/view.goTotal diff: +0 additions, -2 deletions
Testing & Verification
✅
go build ./...passes with no errors✅
go vet ./pkg/views/member/view/...passes with no warnings✅ No functional changes to view rendering
✅ Verified
columnsvariable still correctly used in table model✅ Confirmed no other code in
pkg/views/uses barelog.Printlnfor debugImpact
Context
No other view files in
pkg/views/use barelog.Printlnstatements. The view layer should only render output, not perform logging.Fixes #5