refactor: make HTTP error code parsing robust#1013
Open
saiashok0981 wants to merge 1 commit into
Open
Conversation
Signed-off-by: saiashok103@gmail.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch: fix/robust-error-code-parsing
Commit: [fix/robust-error-code-parsing e275281]
Changes:
Refactored ParseHarborErrorCode in
error.go
to use a regular expression:
go
reBracket := regexp.MustCompile(
\]\s*\[(\d{3})\])This matches any 3-digit status code enclosed in brackets that is preceded by a closing bracket (with or without spaces), rather than relying on splitting string indices.
Added new comprehensive unit test cases in
error_test.go
to ensure reliability for wrapped bracketed messages, spaced bracket formats, and prefix brackets.