fix(robot): handle empty permissions in robot view#998
Open
Jay2006sawant wants to merge 1 commit into
Open
Conversation
Fixes goharbor#997 Signed-off-by: Jay2006sawant <jay242902@gmail.com>
Author
|
@Vad1mo Can you please look into this? |
NucleoFusion
left a comment
NucleoFusion
left a comment
Contributor
There was a problem hiding this comment.
I dont think so we can create robots with 0 permissions. (I confirmed you cant)
But i think the gaurd is not a bad to have.
@qcserestipy what do you think? Should we have it or is it redundant?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
harbor robot viewpanics when the Harbor API returns a robot with an empty or nilpermissionsarray. The view indexedrobot.Permissions[0]unconditionally, whileharbor robot listalready guarded this case.This PR adds safe fallbacks for the permission count and project namespace header, matching the list view behavior.
Type of Change
Changes
robotPermissionSummaryhelper to safely read permission count and namespace0,--) when permission details are missingTest plan
go test ./pkg/views/robot/view/... -vrobotPermissionSummaryreturns safe defaults for nil/empty permissions (no index panic)